Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Commit 1a24ea7

Browse files
committed
fix(entity): Use field comparsion for test
1 parent c18b328 commit 1a24ea7

File tree

2 files changed

+22
-38
lines changed

2 files changed

+22
-38
lines changed

tests/Entity/QuestionDtoTest.php

Lines changed: 14 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,13 @@ public function testEntityToDto(): void
3333

3434
$questionDto = QuestionDto::fromEntity($entity);
3535

36-
self::assertSame(
37-
(new QuestionDto())
38-
->setSchemaId('1')
39-
->setType('type')
40-
->setDifficulty(QuestionDifficulty::Easy)
41-
->setTitle('QuestionTest')
42-
->setDescription('DescriptionTest')
43-
->setAnswer('AnswerTest')
44-
->setSolutionVideo('SolutionVideoTest'),
45-
$questionDto,
46-
);
36+
self::assertSame('1', $questionDto->getSchemaId());
37+
self::assertSame('type', $questionDto->getType());
38+
self::assertSame(QuestionDifficulty::Easy, $questionDto->getDifficulty());
39+
self::assertSame('QuestionTest', $questionDto->getTitle());
40+
self::assertSame('DescriptionTest', $questionDto->getDescription());
41+
self::assertSame('AnswerTest', $questionDto->getAnswer());
42+
self::assertSame('SolutionVideoTest', $questionDto->getSolutionVideo());
4743
}
4844

4945
/**
@@ -69,16 +65,12 @@ public function testToEntity(): void
6965

7066
$entity = $questionDto->toEntity($schemaRepository);
7167

72-
self::assertSame(
73-
(new Question())
74-
->setSchema((new Schema())->setId('1'))
75-
->setType('type')
76-
->setDifficulty(QuestionDifficulty::Easy)
77-
->setTitle('QuestionTest')
78-
->setDescription('DescriptionTest')
79-
->setAnswer('AnswerTest')
80-
->setSolutionVideo('SolutionVideoTest'),
81-
$entity,
82-
);
68+
self::assertSame('1', $entity->getSchema()->getId());
69+
self::assertSame('type', $entity->getType());
70+
self::assertSame(QuestionDifficulty::Easy, $entity->getDifficulty());
71+
self::assertSame('QuestionTest', $entity->getTitle());
72+
self::assertSame('DescriptionTest', $entity->getDescription());
73+
self::assertSame('AnswerTest', $entity->getAnswer());
74+
self::assertSame('SolutionVideoTest', $entity->getSolutionVideo());
8375
}
8476
}

tests/Entity/SchemaDtoTest.php

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,10 @@ public function testEntityToDto(): void
2626

2727
$schemaDto = SchemaDto::fromEntity($entity);
2828

29-
self::assertSame(
30-
(new SchemaDto())
31-
->setId('SchemaId')
32-
->setPicture('PictureTest')
33-
->setDescription('DescriptionTest')
34-
->setSchema('SchemaTest'),
35-
$schemaDto,
36-
);
29+
self::assertSame('SchemaId', $schemaDto->getId());
30+
self::assertSame('PictureTest', $schemaDto->getPicture());
31+
self::assertSame('DescriptionTest', $schemaDto->getDescription());
32+
self::assertSame('SchemaTest', $schemaDto->getSchema());
3733
}
3834

3935
public function testEntityToDtoWithoutPicture(): void
@@ -46,14 +42,10 @@ public function testEntityToDtoWithoutPicture(): void
4642

4743
$schemaDto = SchemaDto::fromEntity($entity);
4844

49-
self::assertSame(
50-
(new SchemaDto())
51-
->setId('SchemaId')
52-
->setPicture(null)
53-
->setDescription('DescriptionTest')
54-
->setSchema('SchemaTest'),
55-
$schemaDto,
56-
);
45+
self::assertSame('SchemaId', $schemaDto->getId());
46+
self::assertNull($schemaDto->getPicture());
47+
self::assertSame('DescriptionTest', $schemaDto->getDescription());
48+
self::assertSame('SchemaTest', $schemaDto->getSchema());
5749
}
5850

5951
public function testToEntity(): void

0 commit comments

Comments
 (0)