refactor(questions): Move pass rate logic to Question

Author: pan93412

src/Entity/Question.php

@@ -176,6 +176,44 @@ public function setSolutionVideo(?string $solution_video): static
         return $this;
     }
 
+    /**
+     * Get the pass rate of the question.
+     *
+     * @return float the pass rate of the question
+     */
+    public function getPassRate(): float
+    {
+        $totalAttemptCount = $this->getTotalAttemptCount();
+        if (0 === $totalAttemptCount) {
+            return 0;
+        }
+
+        return round($this->getTotalSolvedCount() / $totalAttemptCount * 100, 2);
+    }
+
+    /**
+     * Get the total number of attempts made on the question.
+     *
+     * @return int the total number of attempts made on the question
+     */
+    public function getTotalAttemptCount(): int
+    {
+        return $this->getSolutionEvents()->count();
+    }
+
+    /**
+     * Get the total number of times the question has been solved.
+     *
+     * @return int the total number of times the question has been solved
+     */
+    public function getTotalSolvedCount(): int
+    {
+        return $this->getSolutionEvents()
+            ->filter(
+                fn (SolutionEvent $solutionEvent) => SolutionEventStatus::Passed === $solutionEvent->getStatus()
+            )->count();
+    }
+
     /**
      * @return Collection<int, SolutionEvent>
      */

src/Twig/Components/Questions/Card.php

@@ -5,30 +5,13 @@
 namespace App\Twig\Components\Questions;
 
 use App\Entity\Question;
-use App\Entity\SolutionEvent;
-use App\Entity\SolutionEventStatus;
 use Symfony\UX\TwigComponent\Attribute\AsTwigComponent;
 
 #[AsTwigComponent]
 final class Card
 {
     public Question $question;
 
-    /**
-     * Get the pass rate of the question.
-     *
-     * @return float the pass rate of the question
-     */
-    public function getPassRate(): float
-    {
-        $totalAttemptCount = $this->getTotalAttemptCount();
-        if (0 === $totalAttemptCount) {
-            return 0;
-        }
-
-        return round($this->getTotalSolvedCount() / $totalAttemptCount * 100, 2);
-    }
-
     /**
      * Get the pass rate level of the question.
      *
@@ -38,35 +21,12 @@ public function getPassRate(): float
      */
     public function getPassRateLevel(): string
     {
-        $passRate = $this->getPassRate();
+        $passRate = $this->question->getPassRate();
 
         return match (true) {
             $passRate <= 40 => 'low',
             $passRate <= 70 => 'medium',
             default => 'high',
         };
     }
-
-    /**
-     * Get the total number of attempts made on the question.
-     *
-     * @return int the total number of attempts made on the question
-     */
-    private function getTotalAttemptCount(): int
-    {
-        return $this->question->getSolutionEvents()->count();
-    }
-
-    /**
-     * Get the total number of times the question has been solved.
-     *
-     * @return int the total number of times the question has been solved
-     */
-    private function getTotalSolvedCount(): int
-    {
-        return $this->question->getSolutionEvents()
-            ->filter(
-                fn (SolutionEvent $solutionEvent) => SolutionEventStatus::Passed === $solutionEvent->getStatus()
-            )->count();
-    }
 }

templates/components/Questions/Card.html.twig

@@ -11,7 +11,7 @@
 
             <div class="question-card__operations">
                 <a role="button" class="btn btn-primary" href="{{ path('app_challenge', {id: question.id}) }}">進行測驗</a>
-                <div class="question-card__pass-rate" data-pass-rate="{{ this.passRateLevel }}">通過率 {{ this.passRate }}%</div>
+                <div class="question-card__pass-rate" data-pass-rate="{{ this.passRateLevel }}">通過率 {{ question.passRate }}%</div>
             </div>
 
             <div class="question-card__background">