DEL: Deprecate mode param in get_cost

Author: robertmaierle

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.43.0 - TBD
+
+### Breaking changes
+- Removed `mode` parameter in `Historical::MetadataGetCost()`
+
 ## 0.42.0 - 2025-08-19
 
 ### Enhancements

include/databento/historical.hpp

@@ -139,11 +139,11 @@ class Historical {
   double MetadataGetCost(const std::string& dataset,
                          const DateTimeRange<UnixNanos>& datetime_range,
                          const std::vector<std::string>& symbols, Schema schema,
-                         FeedMode mode, SType stype_in, std::uint64_t limit);
+                         SType stype_in, std::uint64_t limit);
   double MetadataGetCost(const std::string& dataset,
                          const DateTimeRange<std::string>& datetime_range,
                          const std::vector<std::string>& symbols, Schema schema,
-                         FeedMode mode, SType stype_in, std::uint64_t limit);
+                         SType stype_in, std::uint64_t limit);
 
   /*
    * Symbology API

src/historical.cpp

@@ -665,25 +665,23 @@ double Historical::MetadataGetCost(const std::string& dataset,
                                    const std::vector<std::string>& symbols,
                                    Schema schema) {
   return this->MetadataGetCost(dataset, datetime_range, symbols, schema,
-                               FeedMode::HistoricalStreaming, kDefaultSTypeIn, {});
+                               kDefaultSTypeIn, {});
 }
 double Historical::MetadataGetCost(const std::string& dataset,
                                    const DateTimeRange<std::string>& datetime_range,
                                    const std::vector<std::string>& symbols,
                                    Schema schema) {
   return this->MetadataGetCost(dataset, datetime_range, symbols, schema,
-                               FeedMode::HistoricalStreaming, kDefaultSTypeIn, {});
+                               kDefaultSTypeIn, {});
 }
 double Historical::MetadataGetCost(const std::string& dataset,
                                    const DateTimeRange<UnixNanos>& datetime_range,
                                    const std::vector<std::string>& symbols,
-                                   Schema schema, FeedMode mode, SType stype_in,
-                                   std::uint64_t limit) {
+                                   Schema schema, SType stype_in, std::uint64_t limit) {
   httplib::Params params{
       {"dataset", dataset},
       {"start", ToString(datetime_range.start)},
       {"symbols", JoinSymbolStrings(kMetadataGetCostEndpoint, symbols)},
-      {"mode", ToString(mode)},
       {"schema", ToString(schema)},
       {"stype_in", ToString(stype_in)}};
   detail::SetIfPositive(&params, "end", datetime_range.end);
@@ -693,13 +691,11 @@ double Historical::MetadataGetCost(const std::string& dataset,
 double Historical::MetadataGetCost(const std::string& dataset,
                                    const DateTimeRange<std::string>& datetime_range,
                                    const std::vector<std::string>& symbols,
-                                   Schema schema, FeedMode mode, SType stype_in,
-                                   std::uint64_t limit) {
+                                   Schema schema, SType stype_in, std::uint64_t limit) {
   httplib::Params params{
       {"dataset", dataset},
       {"start", datetime_range.start},
       {"symbols", JoinSymbolStrings(kMetadataGetCostEndpoint, symbols)},
-      {"mode", ToString(mode)},
       {"schema", ToString(schema)},
       {"stype_in", ToString(stype_in)}};
   detail::SetIfNotEmpty(&params, "end", datetime_range.end);

tests/src/historical_tests.cpp

@@ -552,7 +552,6 @@ TEST_F(HistoricalTests, TestMetadataGetCost_Full) {
                             {{"dataset", dataset::kGlbxMdp3},
                              {"start", "2020-06-06T00:00"},
                              {"end", "2021-03-02T00:00"},
-                             {"mode", "historical-streaming"},
                              {"symbols", "MES.OPT,EW.OPT"},
                              {"schema", "tbbo"},
                              {"stype_in", "parent"}},
@@ -562,8 +561,7 @@ TEST_F(HistoricalTests, TestMetadataGetCost_Full) {
   databento::Historical target = Client(port);
   const auto res = target.MetadataGetCost(
       dataset::kGlbxMdp3, {"2020-06-06T00:00", "2021-03-02T00:00"},
-      {"MES.OPT", "EW.OPT"}, Schema::Tbbo, FeedMode::HistoricalStreaming, SType::Parent,
-      {});
+      {"MES.OPT", "EW.OPT"}, Schema::Tbbo, SType::Parent, {});
   ASSERT_DOUBLE_EQ(res, kResp);
 }