Import-DbaCsv - Move library to Dataplat.Dbatools.Csv 😍 + Export-DbaCsv (#10005)

Author: potatoqualitee

.github/dbatools-library-version.json

@@ -1,4 +1,4 @@
 {
-  "version": "2025.11.12",
-  "notes": "Version of dbatools.library to use for CI/CD and development"
+  "version": "2025.11.29-preview-new-20251129132142",
+  "notes": "Version of dbatools.library to use for CI/CD and development."
 }

dbatools.psd1

@@ -419,6 +419,7 @@
         'Get-DbaXESessionTemplate',
         'Get-DbaXEStore',
         'Grant-DbaAgPermission',
+        'Export-DbaCsv',
         'Import-DbaCsv',
         'Import-DbaPfDataCollectorSetTemplate',
         'Import-DbaRegServer',

dbatools.psm1

@@ -715,6 +715,7 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
         'Unregister-DbatoolsConfig',
         'Join-DbaPath',
         'Resolve-DbaPath',
+        'Export-DbaCsv',
         'Import-DbaCsv',
         'Invoke-DbaDbDataMasking',
         'New-DbaDbMaskingConfig',

public/Export-DbaCsv.ps1

@@ -108,13 +108,36 @@ function Remove-DbaCustomError {
 
             if ($Pscmdlet.ShouldProcess($instance, "Removing server message with id $MessageID from $instance")) {
                 Write-Message -Level Verbose -Message "Removing server message with id $MessageID and language $Language from $instance"
+
+                # Use sp_dropmessage directly - more reliable than SMO Drop() method
+                # sp_dropmessage handles the proper drop order automatically
                 try {
-                    # find the message using language or languageID or the 'session language' message if they specified 'all'. SMO will drop all related messages for an ID if the english message is dropped.
-                    $userDefinedMessage = $server.UserDefinedMessages | Where-Object { $_.ID -eq $MessageID -and ($_.Language -in $languageName, $languageAlias -or $_.LanguageID -eq $langId -or ($Language -ieq "All" -and $_.Language -like "*english")) }
-                    $userDefinedMessage.Drop()
+                    if ($Language -ieq "All") {
+                        $server.Query("EXEC sp_dropmessage @msgnum = $MessageID, @lang = 'all'")
+                    } else {
+                        # Check if this is English and other language versions exist
+                        # SQL Server requires all localized versions to be dropped before us_english
+                        # If dropping English, we must drop all versions
+                        if ($languageName -eq "us_english") {
+                            $otherLanguages = $server.Query("SELECT COUNT(*) AS cnt FROM sys.messages WHERE message_id = $MessageID AND language_id <> 1033")
+                            if ($otherLanguages.cnt -gt 0) {
+                                # Other languages exist, must drop all
+                                $server.Query("EXEC sp_dropmessage @msgnum = $MessageID, @lang = 'all'")
+                            } else {
+                                # Only English exists, drop just English
+                                $server.Query("EXEC sp_dropmessage @msgnum = $MessageID, @lang = '$languageName'")
+                            }
+                        } else {
+                            # Non-English language, drop just that language
+                            $server.Query("EXEC sp_dropmessage @msgnum = $MessageID, @lang = '$languageName'")
+                        }
+                    }
                 } catch {
-                    Stop-Function -Message "Error occurred while trying to remove a message with id $MessageID from $instance" -ErrorRecord $_ -Continue
+                    Stop-Function -Message "Error occurred while trying to remove message $MessageID from $instance" -ErrorRecord $_ -Continue
                 }
+
+                # Refresh the UserDefinedMessages collection to reflect the changes
+                $server.UserDefinedMessages.Refresh()
             }
         }
     }

public/Import-DbaCsv.ps1

@@ -184,8 +184,8 @@ Describe $CommandName -Tag IntegrationTests {
         AfterAll {
             $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
-            $null = $sourceDb.Query("DROP TABLE IF EXISTS dbo.dbatoolsci_computed_source")
-            $null = $destinationDb.Query("DROP TABLE IF EXISTS dbo.dbatoolsci_computed_dest")
+            $null = $sourceDb.Query("IF OBJECT_ID('dbo.dbatoolsci_computed_source', 'U') IS NOT NULL DROP TABLE dbo.dbatoolsci_computed_source")
+            $null = $destinationDb.Query("IF OBJECT_ID('dbo.dbatoolsci_computed_dest', 'U') IS NOT NULL DROP TABLE dbo.dbatoolsci_computed_dest")
 
             $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
         }
@@ -211,8 +211,8 @@ Describe $CommandName -Tag IntegrationTests {
         AfterAll {
             $PSDefaultParameterValues["*-Dba*:EnableException"] = $true
 
-            $null = $sourceDb.Query("DROP TABLE IF EXISTS dbo.dbatoolsci_ordering_test")
-            $null = $destinationDb.Query("DROP TABLE IF EXISTS dbo.dbatoolsci_ordering_test_dest")
+            $null = $sourceDb.Query("IF OBJECT_ID('dbo.dbatoolsci_ordering_test', 'U') IS NOT NULL DROP TABLE dbo.dbatoolsci_ordering_test")
+            $null = $destinationDb.Query("IF OBJECT_ID('dbo.dbatoolsci_ordering_test_dest', 'U') IS NOT NULL DROP TABLE dbo.dbatoolsci_ordering_test_dest")
 
             $PSDefaultParameterValues.Remove("*-Dba*:EnableException")
         }