Improved Metrics (#533)

kraftp · web-flow · commit 85b8073c4933 · 2025-12-03T14:44:35.000-08:00
Steps should be recorded as of their completion time, not their start
time, as they aren't recorded until completed.
diff --git a/dbos/_sys_db.py b/dbos/_sys_db.py
@@ -2341,9 +2341,9 @@ def get_metrics(self, start_time: str, end_time: str) -> List[MetricData]:
                 )
                 .where(
                     sa.and_(
-                        SystemSchema.operation_outputs.c.started_at_epoch_ms
+                        SystemSchema.operation_outputs.c.completed_at_epoch_ms
                         >= start_epoch_ms,
-                        SystemSchema.operation_outputs.c.started_at_epoch_ms
+                        SystemSchema.operation_outputs.c.completed_at_epoch_ms
                         < end_epoch_ms,
                     )
                 )

Original file line number	Diff line number	Diff line change
`@@ -2341,9 +2341,9 @@ def get_metrics(self, start_time: str, end_time: str) -> List[MetricData]:`
`2341`	`2341`	`)`
`2342`	`2342`	`.where(`
`2343`	`2343`	`sa.and_(`
`2344`		`- SystemSchema.operation_outputs.c.started_at_epoch_ms`
	`2344`	`+ SystemSchema.operation_outputs.c.completed_at_epoch_ms`
`2345`	`2345`	`>= start_epoch_ms,`
`2346`		`- SystemSchema.operation_outputs.c.started_at_epoch_ms`
	`2346`	`+ SystemSchema.operation_outputs.c.completed_at_epoch_ms`
`2347`	`2347`	`< end_epoch_ms,`
`2348`	`2348`	`)`
`2349`	`2349`	`)`