Skip to content

Commit 8d3f861

Browse files
committed
test: fix test warnings and reorganize test files
- Fix React key prop warning in AdvancedQRCode tests by separating forEach iterations into individual test cases - Move test SVG files and detectability script to test/ directory - Update .gitignore to exclude test output files - Better organize test structure for maintainability
1 parent fed6eb4 commit 8d3f861

10 files changed

+21
-71
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,7 @@ dist
2121
## this is generated by `npm pack`
2222
*.tgz
2323
package
24+
25+
## test outputs
26+
test/svg-detectability/*.svg
27+
test/svg-detectability/detectability-report.json

src/__tests__/AdvancedQRCode.test.tsx

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ describe('AdvancedQRCode', () => {
436436
expect(svg).toBeInTheDocument()
437437
})
438438

439-
it('should support color blind modes', () => {
439+
describe('color blind modes', () => {
440440
const modes = [
441441
'protanopia',
442442
'deuteranopia',
@@ -445,19 +445,21 @@ describe('AdvancedQRCode', () => {
445445
] as const
446446

447447
modes.forEach((mode) => {
448-
const { container } = render(
449-
<AdvancedQRCode
450-
value="test"
451-
advancedStyle={{
452-
accessibility: {
453-
colorBlindMode: mode,
454-
},
455-
}}
456-
/>
457-
)
448+
it(`should support ${mode} mode`, () => {
449+
const { container } = render(
450+
<AdvancedQRCode
451+
value="test"
452+
advancedStyle={{
453+
accessibility: {
454+
colorBlindMode: mode,
455+
},
456+
}}
457+
/>
458+
)
458459

459-
const svg = container.querySelector('svg')
460-
expect(svg).toBeInTheDocument()
460+
const svg = container.querySelector('svg')
461+
expect(svg).toBeInTheDocument()
462+
})
461463
})
462464
})
463465

test-svgs/detectability-report.json

Lines changed: 0 additions & 50 deletions
This file was deleted.

test-svgs/simple-usage-svg-0.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

test-svgs/simple-usage-svg-1.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

test-svgs/simple-usage-svg-2.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

test-svgs/simple-usage-svg-3.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

test-svgs/simple-usage-svg-4.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

test-svgs/simple-usage-svg-5.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ const path = require('path')
1616
const QrScanner = require('qr-scanner')
1717

1818
// Directory paths
19-
const EXAMPLES_DIR = path.join(__dirname, 'examples')
20-
const TEST_OUTPUT_DIR = path.join(__dirname, 'test-svgs')
19+
const EXAMPLES_DIR = path.join(__dirname, '..', 'examples')
20+
const TEST_OUTPUT_DIR = path.join(__dirname, 'svg-detectability')
2121

2222
// HTML files to test
2323
const HTML_FILES = [

0 commit comments

Comments
 (0)