Skip to content

Commit b247cbe

Browse files
authored
Merge pull request #5 from Klowner/python3
few cleanups for python3
2 parents 4fc072a + 48d6fe3 commit b247cbe

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

gitlab3/__init__.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def fn(limit=None, page=None, per_page=None, **data):
8080
data['per_page'] = _MAX_PER_PAGE
8181
num_pages = int(ceil(float(limit) / _MAX_PER_PAGE))
8282
remainder = limit % _MAX_PER_PAGE
83-
for i in xrange(1, num_pages+1):
83+
for i in range(1, num_pages+1):
8484
data['page'] = i
8585
objs = parent._get(api._uq_url, data=data)
8686
if remainder and i == num_pages: # Final request
@@ -103,7 +103,7 @@ def _find_matches(objects, kwargs, find_all):
103103
for obj in objects:
104104
match = True
105105
# Match all supplied parameters
106-
for param, val in kwargs.iteritems():
106+
for param, val in list(kwargs.items()):
107107
if not getattr(obj, param) == val:
108108
match = False
109109
break
@@ -178,7 +178,7 @@ def fn(*args, **kwargs):
178178
kwargs[param] = args[idx]
179179
idx += 1
180180
# Load kwargs with unnamed optional params
181-
for i in xrange(idx, len(args)):
181+
for i in range(idx, len(args)):
182182
kwargs[optional_params[i-idx]] = args[i]
183183

184184
data = parent._post(api._uq_url, data=kwargs)
@@ -314,10 +314,10 @@ def __init__(self, parent, json_data={}):
314314
pass
315315
if self._convert_dates_enabled:
316316
self._convert_dates(json_data)
317-
for key, val in json_data.iteritems():
317+
for key, val in list(json_data.items()):
318318
setattr(self, key, val)
319319
self._parent = parent
320-
self._data_keys = json_data.keys()
320+
self._data_keys = list(json_data.keys())
321321
for sub_api in self._sub_apis:
322322
_add_api(sub_api, self)
323323
self._sub_apis = None
@@ -336,7 +336,7 @@ def _convert_dates(self, data):
336336
for item in data:
337337
self._convert_dates(item)
338338
return
339-
for key, val in data.iteritems():
339+
for key, val in list(data.items()):
340340
if type(val) == dict:
341341
self._convert_dates(val)
342342
if self._date_fields.get(key) and val:
@@ -434,7 +434,7 @@ def _request(self, request_fn, api_url, addl_keys, data):
434434
raise exceptions.ConnectionError(msg)
435435
self._check_status_code(r.status_code, url, data)
436436
try:
437-
return json.loads(r.content)
437+
return json.loads(r.content.decode())
438438
except ValueError: # XXX: assume we're returning plain text
439439
return r.content
440440

0 commit comments

Comments
 (0)