Comments

LarryKlugerDS · LarryKlugerDS · commit a84b0e4e7e22 · 2018-10-16T10:21:27.000+03:00
diff --git a/lib/examples/eg001EmbeddedSigning.js b/lib/examples/eg001EmbeddedSigning.js
@@ -118,7 +118,6 @@ eg001EmbeddedSigning.createController = async (req, res) => {
  * embedded Signing Ceremony
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
  *      <tt>signerEmail</tt>, <tt>signerName</tt>, <tt>signerClientId</tt>
diff --git a/lib/examples/eg002SigningViaEmail.js b/lib/examples/eg002SigningViaEmail.js
@@ -119,7 +119,6 @@ eg002SigningViaEmail.createController = async (req, res) => {
  * This function does the work of creating the envelope 
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
  *      <tt>status</tt>: envelope status: "sent" | "created"
diff --git a/lib/examples/eg003ListEnvelopes.js b/lib/examples/eg003ListEnvelopes.js
@@ -99,7 +99,6 @@ eg003ListEnvelopes.createController = async (req, res) => {
  * This function does the work of listing the envelopes
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  */
 // ***DS.worker.start ***DS.snippet.1.start
diff --git a/lib/examples/eg004EnvelopeInfo.js b/lib/examples/eg004EnvelopeInfo.js
@@ -111,7 +111,6 @@ eg004EnvelopeInfo.createController = async (req, res) => {
  * This function does the work of getting the envelope information
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeId</tt>: envelope Id <br/>
  */
diff --git a/lib/examples/eg005EnvelopeRecipients.js b/lib/examples/eg005EnvelopeRecipients.js
@@ -111,7 +111,6 @@ eg005EnvelopeRecipients.createController = async (req, res) => {
  * This function does the work of listing the envelope's recipients
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeId</tt>: envelope Id <br/>
  */
diff --git a/lib/examples/eg006EnvelopeDocs.js b/lib/examples/eg006EnvelopeDocs.js
@@ -129,7 +129,6 @@ eg006EnvelopeDocs.createController = async (req, res) => {
  * This function does the work of listing the envelope's documents
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeId</tt>: envelope Id <br/>
  */
diff --git a/lib/examples/eg007EnvelopeGetDoc.js b/lib/examples/eg007EnvelopeGetDoc.js
@@ -129,7 +129,6 @@ eg007EnvelopeGetDoc.createController = async (req, res) => {
  * This function does the work of listing the envelope's recipients
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>documentId</tt>: the document to be fetched <br/>
  *   <tt>envelopeDocuments</tt>: object with data about the envelope's documents
diff --git a/lib/examples/eg008CreateTemplate.js b/lib/examples/eg008CreateTemplate.js
@@ -108,7 +108,6 @@ eg008CreateTemplate.createController = async (req, res) => {
    * This function does the work of checking to see if the template exists and creating it if not.
    * @param {object} args An object with the following elements: <br/>
    *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
-   *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
    *   <tt>accountId</tt>: Current account Id <br/>
    *   <tt>templateName</tt>: The template's name <br/>
    */
diff --git a/lib/examples/eg009UseTemplate.js b/lib/examples/eg009UseTemplate.js
@@ -126,7 +126,6 @@ eg009UseTemplate.createController = async (req, res) => {
  * This function does the work of creating the envelope 
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
  *      <tt>templateId</tt>, <tt>signerEmail</tt>, <tt>signerName</tt>, 
diff --git a/lib/examples/eg011EmbeddedSending.js b/lib/examples/eg011EmbeddedSending.js
@@ -121,7 +121,6 @@ eg011EmbeddedSending.createController = async (req, res) => {
  * draft mode and returning a URL for the sender's view
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>senderView</tt>: tagging or recipient
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
diff --git a/lib/examples/eg012EmbeddedConsole.js b/lib/examples/eg012EmbeddedConsole.js
@@ -108,7 +108,6 @@ eg012EmbeddedConsole.createController = async (req, res) => {
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set 
  *       with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>dsReturnUrl</tt>: the return url back to this app
  *   <tt>envelopeId</tt>: optional envelope for the NDSE to focus on
diff --git a/lib/examples/eg013AddDocToTemplate.js b/lib/examples/eg013AddDocToTemplate.js
@@ -139,7 +139,6 @@ eg013AddDocToTemplate.createController = async (req, res) => {
  * embedded Signing Ceremony
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
  *      <tt>templateId</tt>, <tt>item</tt>, <tt>quantity</tt>
diff --git a/lib/examples/eg014CollectPayment.js b/lib/examples/eg014CollectPayment.js
@@ -121,7 +121,6 @@ eg014CollectPayment.createController = async (req, res) => {
  * This function does the work of creating the envelope 
  * @param {object} args An object with the following elements: <br/>
  *   <tt>dsAPIclient</tt>: The DocuSign API Client object, already set with an access token and base url <br/>
- *   <tt>makePromise</tt>: Function for promisfying an SDK method <br/>
  *   <tt>accountId</tt>: Current account Id <br/>
  *   <tt>envelopeArgs</tt>: envelopeArgs, an object with elements 
  *      <tt>status</tt>: envelope status: "sent" | "created"
diff --git a/test/eg001.js b/test/eg001.js
@@ -23,7 +23,6 @@ describe ('eg001', function(){
         }
       , args = {
             dsAPIclient: helpers.dsAPIclient,
-            makePromise: helpers.makePromise, // this is a function
             accountId: helpers.accountId,
             envelopeArgs: envelopeArgs
         }
diff --git a/test/eg002.js b/test/eg002.js
@@ -23,7 +23,6 @@ describe ('eg002 (test takes a long time to create an envelope with 3 documents)
         }
       , args = {
             dsAPIclient: helpers.dsAPIclient,
-            makePromise: helpers.makePromise, // this is a function
             accountId: helpers.accountId,
             envelopeArgs: envelopeArgs
         }
diff --git a/test/testHelpers.js b/test/testHelpers.js
@@ -14,14 +14,6 @@ helpers.ccEmail = 'ds_test_cc@mailinator.com';
 helpers.ccName = 'Mocha CC Tester';
 helpers.signerClientId = 1000;
 
-helpers.makePromise = function _makePromise(obj, methodName){
-    let promiseName = methodName + '_promise';
-    if (!(promiseName in obj)) {
-      obj[promiseName] = promisify(obj[methodName]).bind(obj)
-    }
-    return obj[promiseName]
-}
-
 helpers.dsAPIclient = new docusign.ApiClient();
 helpers.dsAPIclient.addDefaultHeader('Authorization', 'Bearer ' + helpers.accessToken);
 helpers.dsAPIclient.setBasePath(helpers.basePath);
