fixes

Author: RomanBachaloSigmaSoftware

lib/admin/controllers/eg008UpdateUserProductPermissionProfile.js

@@ -5,9 +5,9 @@
  */
 
 const path = require('path')
+const validator = require('validator');
 const { updateUserProductPermissionProfile, getProductPermissionProfiles } = require('../examples/updateUserProductPermissionProfile');
 const dsConfig = require('../../../config/index.js').config;
-const validator = require('validator');
 const { getOrganizationId } = require("../getOrganizationId.js");
 
 const eg008UpdateUserProductPermissionProfile = exports;
@@ -23,15 +23,15 @@ const minimumBufferMin = 3;
 eg008UpdateUserProductPermissionProfile.createController = async (req, res) => {
   // At this point we should have a good token. But we
   // double-check here to enable a better UX to the user.
-  let isTokenOK = req.dsAuth.checkToken(minimumBufferMin);
+  const isTokenOK = req.dsAuth.checkToken(minimumBufferMin);
   if (!isTokenOK) {
     req.flash("info", "Sorry, you need to re-authenticate.");
     // Save the current operation so it will be resumed after authentication
     req.dsAuth.setEg(req, eg);
     return res.redirect(mustAuthenticate);
   }
 
-  if(!req.session.clmEmail) {
+  if (!req.session.clmEmail) {
     return res.render("pages/admin-examples/eg008UpdateUserProductPermissionProfile", {
       eg: eg, csrfToken: req.csrfToken(),
       title: "Update user product permission profiles using an email address",
@@ -43,7 +43,6 @@ eg008UpdateUserProductPermissionProfile.createController = async (req, res) => {
     });
   }
 
-  let results = null;
   const { body } = req;
 
   const productId = validator.escape(body.productId);
@@ -58,14 +57,13 @@ eg008UpdateUserProductPermissionProfile.createController = async (req, res) => {
 
   const { clmProductId } = await getProductPermissionProfiles(args);
 
-  if(productId === clmProductId) {
-    args.permissionProfileId = validator.escape(body.clmPermissionProfileId);
-  } else {
-    args.permissionProfileId = validator.escape(body.eSignPermissionProfileId);
-  }
+  args.permissionProfileId = productId === clmProductId
+    ? validator.escape(body.clmPermissionProfileId)
+    : validator.escape(body.eSignPermissionProfileId)
 
+  let results = null;
   try {
-    results = await updateUserProductPermissionProfile(args)
+    results = await updateUserProductPermissionProfile(args);
   }
   catch (error) {
     const errorBody = error && error.response && error.response.body;
@@ -94,15 +92,15 @@ eg008UpdateUserProductPermissionProfile.getController = async (req, res) => {
   // Check that the authentication token is ok with a long buffer time.
   // If needed, now is the best time to ask the user to authenticate
   // since they have not yet entered any information into the form.
-  let isTokenOK = req.dsAuth.checkToken();
+  const isTokenOK = req.dsAuth.checkToken();
   if (!isTokenOK) {
     // Save the current operation so it will be resumed after authentication
     req.dsAuth.setEg(req, eg);
     return res.redirect(mustAuthenticate);
   }
 
   const sourceFile = (path.basename(__filename))[5].toLowerCase() + (path.basename(__filename)).substr(6);
-  if(!req.session.clmEmail) {
+  if (!req.session.clmEmail) {
     return res.render("pages/admin-examples/eg008UpdateUserProductPermissionProfile", {
       eg: eg, csrfToken: req.csrfToken(),
       title: "Update user product permission profiles using an email address",
@@ -115,7 +113,7 @@ eg008UpdateUserProductPermissionProfile.getController = async (req, res) => {
   }
 
   try {
-    await getOrganizationId(req)
+    await getOrganizationId(req);
     const args = {
       accessToken: req.user.accessToken,
       basePath: dsConfig.adminAPIUrl,

lib/admin/controllers/eg009DeleteUserProductPermissionProfile.js

@@ -5,9 +5,9 @@
  */
 
 const path = require('path')
+const validator = require('validator');
 const { deleteUserProductPermissionProfile, getProductPermissionProfilesByEmail } = require('../examples/deleteUserProductPermissionProfile');
 const dsConfig = require('../../../config/index.js').config;
-const validator = require('validator');
 const { getOrganizationId } = require("../getOrganizationId.js");
 
 const eg009DeleteUserProductPermissionProfile = exports;
@@ -23,15 +23,15 @@ const minimumBufferMin = 3;
 eg009DeleteUserProductPermissionProfile.createController = async (req, res) => {
   // At this point we should have a good token. But we
   // double-check here to enable a better UX to the user.
-  let isTokenOK = req.dsAuth.checkToken(minimumBufferMin);
+  const isTokenOK = req.dsAuth.checkToken(minimumBufferMin);
   if (!isTokenOK) {
     req.flash("info", "Sorry, you need to re-authenticate.");
     // Save the current operation so it will be resumed after authentication
     req.dsAuth.setEg(req, eg);
     return res.redirect(mustAuthenticate);
   }
 
-  if(!req.session.clmEmail) {
+  if (!req.session.clmEmail) {
     return res.render("pages/admin-examples/eg009DeleteUserProductPermissionProfile", {
       eg: eg, csrfToken: req.csrfToken(),
       title: "Delete user product permission profiles using an email address",
@@ -43,7 +43,6 @@ eg009DeleteUserProductPermissionProfile.createController = async (req, res) => {
     });
   }
 
-  let results = null;
   const body = req.body;
   const args = {
     accessToken: req.user.accessToken,
@@ -53,9 +52,10 @@ eg009DeleteUserProductPermissionProfile.createController = async (req, res) => {
     email: req.session.clmEmail,
     productId: validator.escape(body.productId)
   }
-
+  
+  let results = null;
   try {
-    results = await deleteUserProductPermissionProfile(args)
+    results = await deleteUserProductPermissionProfile(args);
   }
   catch (error) {
     const errorBody = error && error.response && error.response.body;
@@ -84,7 +84,7 @@ eg009DeleteUserProductPermissionProfile.getController = async (req, res) => {
   // Check that the authentication token is ok with a long buffer time.
   // If needed, now is the best time to ask the user to authenticate
   // since they have not yet entered any information into the form.
-  let isTokenOK = req.dsAuth.checkToken();
+  const isTokenOK = req.dsAuth.checkToken();
   if (!isTokenOK) {
     req.flash("info", "Sorry, you need to re-authenticate.");
     // Save the current operation so it will be resumed after authentication
@@ -93,7 +93,7 @@ eg009DeleteUserProductPermissionProfile.getController = async (req, res) => {
   }
 
   const sourceFile = (path.basename(__filename))[5].toLowerCase() + (path.basename(__filename)).substr(6);
-  if(!req.session.clmEmail) {
+  if (!req.session.clmEmail) {
     return res.render("pages/admin-examples/eg009DeleteUserProductPermissionProfile", {
       eg: eg, csrfToken: req.csrfToken(),
       title: "Delete user product permission profiles using an email address",
@@ -106,7 +106,7 @@ eg009DeleteUserProductPermissionProfile.getController = async (req, res) => {
   }
 
   try {
-    await getOrganizationId(req)
+    await getOrganizationId(req);
     const args = {
       accessToken: req.user.accessToken,
       basePath: dsConfig.adminAPIUrl,
@@ -119,19 +119,19 @@ eg009DeleteUserProductPermissionProfile.getController = async (req, res) => {
     let permissionProfileList = [];
     let permissionName;
 
-    if(productPermissionProfiles && productPermissionProfiles.length > 0) {
+    // Create the permission profile list that will be used on example page
+    if (productPermissionProfiles && productPermissionProfiles.length > 0) {
       productPermissionProfiles.forEach(product => {
         let permissionProfiles = product["permission_profiles"];
 
         permissionProfiles.forEach(profile => {
-          if(product["product_name"].includes("CLM")) {
-            permissionName = `CLM - ${profile["permission_profile_name"]}`;
-          } else {
-            permissionName = `eSignature - ${profile["permission_profile_name"]}`;
-          }
+          permissionName = product["product_name"].includes("CLM")
+            ? `CLM - ${profile["permission_profile_name"]}`
+            : `eSignature - ${profile["permission_profile_name"]}`;
 
-          if(permissionProfileList.filter(prof => prof["productId"] === product["product_id"]).length === 0) {
-            permissionProfileList.push({ productId: product["product_id"], permissionName})
+          // Add current permission profile data to the list if it was not added yet
+          if (permissionProfileList.filter(prof => prof["productId"] === product["product_id"]).length === 0) {
+            permissionProfileList.push({ productId: product["product_id"], permissionName });
           }
         });
       });