Skip to content

Commit 6aeb643

Browse files
Feature/code examples refactoring (#50)
* esign examples refactored * updated eg011 * click refactored * rooms refactored * monitor refactored * admin examples refactored * refactored esign examples & updated scopes * added methods to parent controllers * added initialize method * fixed worker call * fixed error handling * removed return statement
1 parent 944f124 commit 6aeb643

File tree

110 files changed

+1669
-2223
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+1669
-2223
lines changed

app/controllers/admin_api/eg001_create_user_controller.rb

Lines changed: 29 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,42 @@ class AdminApi::Eg001CreateUserController < EgController
44

55
def create
66
begin
7-
results = AdminApi::Eg001CreateUserService.new(session, request).call
7+
args = {
8+
account_id: session['ds_account_id'],
9+
base_path: session['ds_base_path'],
10+
access_token: session['ds_access_token'],
11+
organization_id: session['organization_id']
12+
}
13+
user_data = {
14+
user_name: param_gsub(params['user_name']),
15+
first_name: param_gsub(params['first_name']),
16+
last_name: param_gsub(params['last_name']),
17+
email: param_gsub(params['email']),
18+
auto_activate_memberships: true,
19+
accounts: [
20+
{
21+
id: args[:account_id],
22+
permission_profile: {
23+
id: request['permission_profile_id']
24+
},
25+
groups: [
26+
{
27+
id: request['group_id']
28+
}
29+
]
30+
}
31+
]
32+
}
33+
34+
results = AdminApi::Eg001CreateUserService.new(args, user_data).worker
835

936
@title = 'Create a new active eSignature user'
1037
@h1 = 'Create a new active eSignature user'
1138
@message = "Results from eSignUserManagement:createUser method:"
1239
@json = results.to_json.to_json
1340
render 'ds_common/example_done'
1441
rescue DocuSign_Admin::ApiError => e
15-
error = JSON.parse e.response_body
16-
@error_code = e.code
17-
@error_message = error['error_description']
18-
render 'ds_common/error'
42+
handle_error(e)
1943
end
2044
end
2145

@@ -37,14 +61,4 @@ def get
3761
@groups = groups_api.list_groups(args[:account_id]).groups
3862
end
3963

40-
private
41-
42-
def check_auth
43-
minimum_buffer_min = 10
44-
token_ok = check_token(minimum_buffer_min)
45-
unless token_ok
46-
flash[:messages] = 'Sorry, you need to re-authenticate.'
47-
redirect_to '/ds/mustAuthenticate'
48-
end
49-
end
5064
end

app/controllers/admin_api/eg002_create_active_clm_esign_user_controller.rb

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,23 @@ class AdminApi::Eg002CreateActiveClmEsignUserController < EgController
33

44
def create
55
begin
6-
results = AdminApi::Eg002CreateActiveClmEsignUserService.new(session, request).call
6+
args = {
7+
user_name: params[:user_name],
8+
first_name: params[:first_name],
9+
last_name: params[:last_name],
10+
email: params[:email],
11+
clm_permission_profile_id: params[:clm_permission_profile_id],
12+
esign_permission_profile_id: params[:esign_permission_profile_id],
13+
clm_product_id: params[:clm_product_id],
14+
esign_product_id: params[:esign_product_id],
15+
ds_group_id: params[:ds_group_id],
16+
account_id: session[:ds_account_id],
17+
organization_id: session['organization_id'],
18+
base_path: session[:ds_base_path],
19+
access_token: session[:ds_access_token]
20+
}
21+
22+
results = AdminApi::Eg002CreateActiveClmEsignUserService.new(args).worker
723

824
@title = "Create a new active user for CLM and eSignature"
925
@h1 = "Create a new active user for CLM and eSignature"
@@ -12,10 +28,7 @@ def create
1228

1329
render 'ds_common/example_done'
1430
rescue DocuSign_Admin::ApiError => e
15-
error = JSON.parse e.response_body
16-
@error_code = e.code
17-
@error_message = error['error_description']
18-
render 'ds_common/error'
31+
handle_error(e)
1932
end
2033
end
2134

@@ -37,17 +50,4 @@ def get
3750
end
3851
@ds_groups = AdminApi::GetDataService.new(session).get_ds_groups
3952
end
40-
41-
private
42-
43-
def check_auth
44-
minimum_buffer_min = 10
45-
token_ok = check_token(minimum_buffer_min)
46-
unless token_ok
47-
flash[:messages] = 'Sorry, you need to re-authenticate.'
48-
# We could store the parameters of the requested operation so it could be restarted automatically
49-
# But since it should be rare to have a token issue here, we'll make the user re-enter the form data after authentication
50-
redirect_to '/ds/mustAuthenticate'
51-
end
52-
end
5353
end

app/controllers/admin_api/eg003_bulk_export_user_data_controller.rb

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,29 +9,27 @@ def create
99
file_path = File.expand_path(File.join(File.dirname(__FILE__), '../../../data/exportedUserData.csv'))
1010

1111
begin
12-
results = AdminApi::Eg003BulkExportUserDataService.new(session, request, file_path).call
12+
request_body = {
13+
type: 'organization_memberships_export'
14+
}
15+
args = {
16+
account_id: session['ds_account_id'],
17+
base_path: session['ds_base_path'],
18+
access_token: session['ds_access_token'],
19+
organization_id: session['organization_id'],
20+
file_path: file_path,
21+
request_body: request_body
22+
}
23+
24+
results = AdminApi::Eg003BulkExportUserDataService.new(args).worker
1325

1426
@title = 'Bulk-export user data'
1527
@h1 = 'Bulk-export user data'
1628
@message = "User data exported to #{file_path}. </br> Results from UserExport::getUserListExport method:"
1729
@json = results.to_json.to_json
1830
render 'ds_common/example_done'
1931
rescue DocuSign_Admin::ApiError => e
20-
error = JSON.parse e.response_body
21-
@error_code = e.code
22-
@error_message = error['error_description']
23-
render 'ds_common/error'
24-
end
25-
end
26-
27-
private
28-
29-
def check_auth
30-
minimum_buffer_min = 10
31-
token_ok = check_token(minimum_buffer_min)
32-
unless token_ok
33-
flash[:messages] = 'Sorry, you need to re-authenticate.'
34-
redirect_to '/ds/mustAuthenticate'
32+
handle_error(e)
3533
end
3634
end
3735
end

app/controllers/admin_api/eg004_import_user_controller.rb

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,15 @@ def create
99
file_path = File.expand_path(File.join(File.dirname(__FILE__), '../../../data/userData.csv'))
1010

1111
begin
12-
results = AdminApi::Eg004ImportUserService.new(session, request, file_path).call
12+
args = {
13+
account_id: session['ds_account_id'],
14+
base_path: session['ds_base_path'],
15+
access_token: session['ds_access_token'],
16+
organization_id: session['organization_id'],
17+
csv_file_path: file_path
18+
}
19+
20+
results = AdminApi::Eg004ImportUserService.new(args).worker
1321
session[:import_id] = results.id
1422

1523
@title = 'Add users via bulk import'
@@ -19,10 +27,7 @@ def create
1927
@json = results.to_json.to_json
2028
render 'ds_common/example_done'
2129
rescue DocuSign_Admin::ApiError => e
22-
error = JSON.parse e.response_body
23-
@error_code = e.code
24-
@error_message = error['error_description']
25-
render 'ds_common/error'
30+
handle_error(e)
2631
end
2732
end
2833

@@ -48,15 +53,4 @@ def check_status
4853
render 'ds_common/error'
4954
end
5055
end
51-
52-
private
53-
54-
def check_auth
55-
minimum_buffer_min = 10
56-
token_ok = check_token(minimum_buffer_min)
57-
unless token_ok
58-
flash[:messages] = 'Sorry, you need to re-authenticate.'
59-
redirect_to '/ds/mustAuthenticate'
60-
end
61-
end
6256
end

app/controllers/admin_api/eg005_audit_users_controller.rb

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,14 @@ def create
77
end
88

99
begin
10-
results = AdminApi::Eg005AuditUsersService.new(session, request).call
10+
args = {
11+
account_id: session[:ds_account_id],
12+
organization_id: session['organization_id'],
13+
base_path: session[:ds_base_path],
14+
access_token: session[:ds_access_token]
15+
}
16+
17+
results = AdminApi::Eg005AuditUsersService.new(args).worker
1118

1219
@title = "Audit users"
1320
@h1 = "Audit users"
@@ -16,23 +23,7 @@ def create
1623

1724
render 'ds_common/example_done'
1825
rescue DocuSign_Admin::ApiError => e
19-
error = JSON.parse e.response_body
20-
@error_code = e.code
21-
@error_message = error['error_description']
22-
render 'ds_common/error'
23-
end
24-
end
25-
26-
private
27-
28-
def check_auth
29-
minimum_buffer_min = 10
30-
token_ok = check_token(minimum_buffer_min)
31-
unless token_ok
32-
flash[:messages] = 'Sorry, you need to re-authenticate.'
33-
# We could store the parameters of the requested operation so it could be restarted automatically
34-
# But since it should be rare to have a token issue here, we'll make the user re-enter the form data after authentication
35-
redirect_to '/ds/mustAuthenticate'
26+
handle_error(e)
3627
end
3728
end
3829
end

app/controllers/clickwrap/eg001_create_clickwrap_controller.rb

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,14 @@ class Clickwrap::Eg001CreateClickwrapController < EgController
22
before_action :check_auth
33

44
def create
5-
results = Clickwrap::Eg001CreateClickwrapService.new(session, request).call
5+
args = {
6+
account_id: session[:ds_account_id],
7+
base_path: session[:ds_base_path],
8+
access_token: session[:ds_access_token],
9+
clickwrap_name: request[:clickwrapName]
10+
}
11+
12+
results = Clickwrap::Eg001CreateClickwrapService.new(args).worker
613

714
session[:clickwrap_id] = results.clickwrap_id
815
session[:clickwrap_name] = results.clickwrap_name
@@ -13,15 +20,4 @@ def create
1320
@json = results.to_json.to_json
1421
render 'ds_common/example_done'
1522
end
16-
17-
private
18-
19-
def check_auth
20-
minimum_buffer_min = 10
21-
token_ok = check_token(minimum_buffer_min)
22-
unless token_ok
23-
flash[:messages] = 'Sorry, you need to re-authenticate.'
24-
redirect_to '/ds/mustAuthenticate'
25-
end
26-
end
2723
end

app/controllers/clickwrap/eg002_activate_clickwrap_controller.rb

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,18 @@ class Clickwrap::Eg002ActivateClickwrapController < EgController
22
before_action :check_auth
33

44
def create
5-
results = Clickwrap::Eg002ActivateClickwrapService.new(session).call
5+
args = {
6+
account_id: session[:ds_account_id],
7+
base_path: session[:ds_base_path],
8+
access_token: session[:ds_access_token],
9+
clickwrap_id: session[:clickwrap_id]
10+
}
11+
12+
results = Clickwrap::Eg002ActivateClickwrapService.new(args).worker
613

714
@title = 'Activating a new clickwrap'
815
@h1 = 'Activating a new clickwrap'
916
@message = "The clickwrap #{results.clickwrap_name} has been activated"
1017
render 'ds_common/example_done'
1118
end
12-
13-
private
14-
15-
def check_auth
16-
minimum_buffer_min = 10
17-
token_ok = check_token(minimum_buffer_min)
18-
unless token_ok
19-
flash[:messages] = 'Sorry, you need to re-authenticate.'
20-
redirect_to '/ds/mustAuthenticate'
21-
end
22-
end
2319
end

app/controllers/clickwrap/eg003_create_new_clickwrap_version_controller.rb

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,19 @@ class Clickwrap::Eg003CreateNewClickwrapVersionController < EgController
22
before_action :check_auth
33

44
def create
5-
results = Clickwrap::Eg003CreateNewClickwrapVersionService.new(session).call
5+
args = {
6+
account_id: session[:ds_account_id],
7+
base_path: session[:ds_base_path],
8+
access_token: session[:ds_access_token],
9+
clickwrap_id: session[:clickwrap_id],
10+
clickwrap_name: session[:clickwrap_name]
11+
}
12+
13+
results = Clickwrap::Eg003CreateNewClickwrapVersionService.new(args).worker
614
puts results.to_json.to_json
715
@title = 'Creating a new clickwrap version'
816
@h1 = 'Creating a new clickwrap version'
917
@message = "Version #{results.version_number} of clickwrap #{results.clickwrap_name} has been created"
1018
render 'ds_common/example_done'
1119
end
12-
13-
private
14-
15-
def check_auth
16-
minimum_buffer_min = 10
17-
token_ok = check_token(minimum_buffer_min)
18-
unless token_ok
19-
flash[:messages] = 'Sorry, you need to re-authenticate.'
20-
redirect_to '/ds/mustAuthenticate'
21-
end
22-
end
2320
end

app/controllers/clickwrap/eg004_list_clickwraps_controller.rb

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,18 @@ class Clickwrap::Eg004ListClickwrapsController < EgController
22
before_action :check_auth
33

44
def create
5-
results = Clickwrap::Eg004ListClickwrapsService.new(session, request).call
5+
args = {
6+
account_id: session[:ds_account_id],
7+
base_path: session[:ds_base_path],
8+
access_token: session[:ds_access_token]
9+
}
10+
11+
results = Clickwrap::Eg004ListClickwrapsService.new(args).worker
612

713
@title = 'List clickwraps results'
814
@h1 = 'List clickwraps results'
915
@message = "Results from the ClickWraps::getClickwraps method:"
1016
@json = results.to_json.to_json
1117
render 'ds_common/example_done'
1218
end
13-
14-
private
15-
16-
def check_auth
17-
minimum_buffer_min = 10
18-
token_ok = check_token(minimum_buffer_min)
19-
unless token_ok
20-
flash[:messages] = 'Sorry, you need to re-authenticate.'
21-
redirect_to '/ds/mustAuthenticate'
22-
end
23-
end
2419
end

0 commit comments

Comments
 (0)