Linting

Author: domdfcoding

MANIFEST.in

@@ -1,6 +1,6 @@
 include __pkginfo__.py
 include LICENSE
 include requirements.txt
-recursive-exclude **/__pycache__ *
+prune **/__pycache__
 recursive-include domdf_python_tools *.pyi
 include domdf_python_tools/py.typed

domdf_python_tools/terminal.py

@@ -185,7 +185,7 @@ def _get_terminal_size_windows() -> Optional[Tuple[int, int]]:  # pragma: no cov
 			size_y = bottom - top + 1
 
 			return size_x, size_y
-	except:
+	except Exception:
 		pass
 
 	return None
@@ -198,7 +198,7 @@ def _get_terminal_size_tput() -> Optional[Tuple[int, int]]:  # pragma: no cover
 		cols = int(subprocess.check_call(shlex.split("tput cols")))
 		rows = int(subprocess.check_call(shlex.split("tput lines")))
 		return cols, rows
-	except:
+	except Exception:
 		return None
 
 
@@ -212,7 +212,7 @@ def ioctl_GWINSZ(fd):
 		try:
 			cr = struct.unpack("hh", fcntl.ioctl(fd, termios.TIOCGWINSZ, "1234"))
 			return cr
-		except:
+		except Exception:
 			pass
 
 	cr = ioctl_GWINSZ(0) or ioctl_GWINSZ(1) or ioctl_GWINSZ(2)
@@ -222,13 +222,13 @@ def ioctl_GWINSZ(fd):
 			fd = os.open(os.ctermid(), os.O_RDONLY)  # type: ignore
 			cr = ioctl_GWINSZ(fd)
 			os.close(fd)
-		except:
+		except Exception:
 			pass
 
 	if not cr:
 		try:
 			cr = (os.environ["LINES"], os.environ["COLUMNS"])
-		except:
+		except Exception:
 			return None
 
 	return int(cr[1]), int(cr[0])

tests/test_units.py

@@ -46,11 +46,11 @@ def test_rmul_errors(self, obj):
 	@pytest.mark.parametrize("obj", units_ints_zero2thousand)
 	def test_pow_errors(self, obj):
 		with pytest.raises(NotImplementedError, match="Powers are not supported for units."):
-			Unit(17)**obj
+			Unit(17)**obj  # pylint: disable=expression-not-assigned
 
 		if isinstance(obj, Unit):
 			with pytest.raises(NotImplementedError, match="Powers are not supported for units."):
-				obj**Unit(17)
+				obj**Unit(17)  # pylint: disable=expression-not-assigned
 
 
 class TestDiv:
@@ -82,9 +82,9 @@ def test_floordiv_errors(self, obj):
 	@pytest.mark.parametrize("obj", units_zero2thousand)
 	def test_modulo_errors(self, obj):
 		with pytest.raises(NotImplementedError, match="Modulo division of a unit by another unit is not allowed."):
-			Unit(17) % obj
+			Unit(17) % obj  # pylint: disable=expression-not-assigned
 		with pytest.raises(NotImplementedError, match="Modulo division of a unit by another unit is not allowed."):
-			obj % Unit(17)
+			obj % Unit(17)  # pylint: disable=expression-not-assigned
 
 	@pytest.mark.parametrize("obj", one2thousand)
 	def test_modulo(self, obj: int):

tox.ini

@@ -115,21 +115,6 @@ deps =
 commands = mypy domdf_python_tools tests
 
 
-[testenv:bandit]
-basepython = python3.6
-
-ignore_errors = true
-changedir = {toxinidir}
-deps =
-	bandit
-whitelist_externals = /usr/bin/printf
-commands =
-	printf "===== Running Bandit on domdf_python_tools ====="
-	bandit domdf_python_tools -r
-	printf "===== Running Bandit on tests ====="
-	bandit tests -r -s B101
-
-
 [testenv:pyup]
 basepython = python3.6
 skip_install = true