Upgrade security warning package. Minor warning fixes as well.

Author: IEvangelist

src/Directory.Packages.props

@@ -88,6 +88,6 @@
     <PackageVersion Include="System.Reflection.TypeExtensions" Version="4.7.0" />
     <PackageVersion Include="xunit" Version="2.4.2" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.4.5" />
-    <PackageVersion Include="Yarp.ReverseProxy" Version="2.0.0" />
+    <PackageVersion Include="Yarp.ReverseProxy" Version="2.0.1" />
   </ItemGroup>
 </Project>

src/Services/Ordering/Ordering.Domain/AggregatesModel/OrderAggregate/Order.cs

@@ -19,24 +19,26 @@ public class Order
 
     private string _description;
 
-
-
     // Draft orders have this set to true. Currently we don't check anywhere the draft status of an Order, but we could do it if needed
+#pragma warning disable CS0414 // The field 'Order._isDraft' is assigned but its value is never used
     private bool _isDraft;
+#pragma warning restore CS0414
 
     // DDD Patterns comment
     // Using a private collection field, better for DDD Aggregate's encapsulation
     // so OrderItems cannot be added from "outside the AggregateRoot" directly to the collection,
-    // but only through the method OrderAggrergateRoot.AddOrderItem() which includes behaviour.
+    // but only through the method OrderAggregateRoot.AddOrderItem() which includes behavior.
     private readonly List<OrderItem> _orderItems;
     public IReadOnlyCollection<OrderItem> OrderItems => _orderItems;
 
     private int? _paymentMethodId;
 
     public static Order NewDraft()
     {
-        var order = new Order();
-        order._isDraft = true;
+        var order = new Order
+        {
+            _isDraft = true
+        };
         return order;
     }
 
@@ -56,13 +58,13 @@ public Order(string userId, string userName, Address address, int cardTypeId, st
         Address = address;
 
         // Add the OrderStarterDomainEvent to the domain events collection 
-        // to be raised/dispatched when comitting changes into the Database [ After DbContext.SaveChanges() ]
+        // to be raised/dispatched when committing changes into the Database [ After DbContext.SaveChanges() ]
         AddOrderStartedDomainEvent(userId, userName, cardTypeId, cardNumber,
                                     cardSecurityNumber, cardHolderName, cardExpiration);
     }
 
     // DDD Patterns comment
-    // This Order AggregateRoot's method "AddOrderitem()" should be the only way to add Items to the Order,
+    // This Order AggregateRoot's method "AddOrderItem()" should be the only way to add Items to the Order,
     // so any behavior (discounts, etc.) and validations are controlled by the AggregateRoot 
     // in order to maintain consistency between the whole Aggregate. 
     public void AddOrderItem(int productId, string productName, decimal unitPrice, decimal discount, string pictureUrl, int units = 1)

src/Services/Ordering/Ordering.Infrastructure/OrderingContext.cs

@@ -50,7 +50,7 @@ public async Task<bool> SaveEntitiesAsync(CancellationToken cancellationToken =
 
         // After executing this line all the changes (from the Command Handler and Domain Event Handlers) 
         // performed through the DbContext will be committed
-        var result = await base.SaveChangesAsync(cancellationToken);
+        _ = await base.SaveChangesAsync(cancellationToken);
 
         return true;
     }
@@ -106,6 +106,8 @@ public void RollbackTransaction()
     }
 }
 
+#nullable enable
+
 public class OrderingContextDesignFactory : IDesignTimeDbContextFactory<OrderingContext>
 {
     public OrderingContext CreateDbContext(string[] args)
@@ -120,12 +122,12 @@ class NoMediator : IMediator
     {
         public IAsyncEnumerable<TResponse> CreateStream<TResponse>(IStreamRequest<TResponse> request, CancellationToken cancellationToken = default)
         {
-            return default;
+            return default!;
         }
 
         public IAsyncEnumerable<object?> CreateStream(object request, CancellationToken cancellationToken = default)
         {
-            return default;
+            return default!;
         }
 
         public Task Publish<TNotification>(TNotification notification, CancellationToken cancellationToken = default) where TNotification : INotification
@@ -140,10 +142,10 @@ public Task Publish(object notification, CancellationToken cancellationToken = d
 
         public Task<TResponse> Send<TResponse>(IRequest<TResponse> request, CancellationToken cancellationToken = default)
         {
-            return Task.FromResult<TResponse>(default);
+            return Task.FromResult<TResponse>(default!);
         }
 
-        public Task<object> Send(object request, CancellationToken cancellationToken = default)
+        public Task<object?> Send(object request, CancellationToken cancellationToken = default)
         {
             return Task.FromResult(default(object));
         }

src/Services/Services.Common/AuthorizeCheckOperationFilter.cs

@@ -16,8 +16,8 @@ public AuthorizeCheckOperationFilter(IConfiguration configuration)
     public void Apply(OpenApiOperation operation, OperationFilterContext context)
     {
         // Check for authorize attribute
-        var hasAuthorize = context.MethodInfo.DeclaringType.GetCustomAttributes(true).OfType<AuthorizeAttribute>().Any() ||
-                            context.MethodInfo.GetCustomAttributes(true).OfType<AuthorizeAttribute>().Any();
+        var hasAuthorize = context.MethodInfo.DeclaringType?.GetCustomAttributes(true)?.OfType<AuthorizeAttribute>().Any() ?? false
+            || context.MethodInfo.GetCustomAttributes(true).OfType<AuthorizeAttribute>().Any();
 
         if (!hasAuthorize) return;