all working

Author: AJEETX

src/Api.Test/EndpointsTests/IntegrationTests/ProductControllerTest.cs

@@ -49,7 +49,7 @@ public async Task GetByIdAsync_Returns_200(string culture, string version)
         {
             // Given
             var client = factory.CreateClient();
-            var authResponse = await client.PostAsync(string.Format(SampleDataV1.readerLoginEndpoint, culture, version, Roles.Reader), null);
+            var authResponse = await client.PostAsync(string.Format(SampleDataV1.readerLoginEndpoint, culture, version, Roles.Admin), null);
             var authDetails = JsonConvert.DeserializeObject<AuthenticateResponse>(await authResponse.Content.ReadAsStringAsync());
             client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", authDetails.Token);
             var addProductResponse = await client.PostAsJsonAsync(string.Format(SampleDataV1.productEndpoint, culture, version), SampleDataV1.Product);
@@ -92,13 +92,12 @@ public async Task PutAsync_Returns_204(string culture, string version)
             var putRequestPayload = new Product
             {
                 Id = products.FirstOrDefault().Id,
-                Name = products.FirstOrDefault().Name,
-                DeliveryPrice = products.FirstOrDefault().DeliveryPrice,
-                Price = products.FirstOrDefault().Price,
-                Description = products.FirstOrDefault().Description
+                Name = "Newname",
+                DeliveryPrice = 11,
+                Price = 22,
+                Description = "newDescription"
             };
-
-            client = await SetupHttpClient(Roles.Reader, culture, version);
+            client = await SetupHttpClient(Roles.Editor, culture, version);
 
             // When
             var response = await client.PutAsJsonAsync(string.Format(SampleDataV1.productEndpoint, culture, version) + $"/{id}", putRequestPayload);
@@ -110,7 +109,7 @@ public async Task PutAsync_Returns_204(string culture, string version)
         private async Task<HttpClient> SetupHttpClient(string role, string culture, string version)
         {
             var client = factory.CreateClient();
-            var authResponse = await client.PostAsync(string.Format(SampleDataV1.readerLoginEndpoint, culture, version, Roles.Reader), null);
+            var authResponse = await client.PostAsync(string.Format(SampleDataV1.readerLoginEndpoint, culture, version, role), null);
             var authDetails = JsonConvert.DeserializeObject<AuthenticateResponse>(await authResponse.Content.ReadAsStringAsync());
             client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", authDetails.Token);
             return client;

src/Api/Endpoints/V1/Products/Update.cs

@@ -1,7 +1,6 @@
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
-using Microsoft.EntityFrameworkCore;
 using System;
 using System.Threading.Tasks;
 using Xero.Demo.Api.Domain.Extension;
@@ -33,13 +32,11 @@ public async Task<IActionResult> PutAsync(Guid id, Product product, string cultu
 
             if (savedProduct == default) return NotFound(string.Format(CustomException.NotFoundException, id));
 
-            var updatedProduct = _db.Products.Update(product);
-
-            var stateUpdated = updatedProduct.State == EntityState.Modified;
+            _db.Products.Update(product);
 
             var count = await _db.SaveChangesAsync();
 
-            return stateUpdated && count == 1 ? NoContent() : StatusCode(StatusCodes.Status500InternalServerError);
+            return count == 1 ? NoContent() : StatusCode(StatusCodes.Status500InternalServerError);
         }
     }
 }