ppc64le: arch/powerpc/tools scripts and kpatch-gcc

[joe-lawrence]

While testing #973, I noticed these errors in ~/.kpatch/build.log:

./arch/powerpc/tools/relocs_check.sh: line 48: /root/kpatch/kpatch-build/kpatch-gcc objdump: No such file or directory
./arch/powerpc/tools/unrel_branch_check.sh: line 26: /root/kpatch/kpatch-build/kpatch-gcc objdump: No such file or directory
./arch/powerpc/tools/unrel_branch_check.sh: line 37: /root/kpatch/kpatch-build/kpatch-gcc objdump: No such file or directory

I'm guessing that skipping these are benign, but could there be other tools scripts that we may need to properly function in the future? I wonder if the scripts are concatentating argv[0] and argv[1] so it's looking for a file called "/root/kpatch/kpatch-build/kpatch-gcc objdump"?

[joe-lawrence]

@kamalesh-babulal - have you seen these in your dev/testing travels?

[kamalesh-babulal]

have you seen these in your dev/testing travels?

@joe-lawrence Sorry, I planned to reply long back, got busy with other things at work. Yes, I started carefully looking for them recently but these warnings should be there for long. The in kernel tools expects the arguments passed to them to be:

"/bin/sh ./arch/powerpc/tools/relocs_check.sh "objdump" "vmlinux"
/bin/sh ./arch/powerpc/tools/unrel_branch_check.sh "objdump" "vmlinux"

They warn about the wrong relocation entries and direct branch(s) from the code below __end_interrupts to the code above __end_interrupts symbol, in case of the relocatable kernel. They do not error out but warn during the kernel build, we need to fix the arguments getting passed to these tools.