Improve protocol type error to list possible root causes

Author: josevalim

lib/elixir/lib/module/types/apply.ex

@@ -1042,7 +1042,10 @@ defmodule Module.Types.Apply do
           else
             # Protocol errors can be very verbose, so we collapse structs
             """
-            but expected a type that implements the #{inspect(mod)} protocol, it must be one of:
+            but expected a type that implements the #{inspect(mod)} protocol. You either passed the wrong \
+            value or you forgot to implement the protocol.
+
+            The #{inspect(mod)} protocol is implemented for the following types:
             #{clauses_args_to_quoted_string(clauses, converter, collapse_structs: true)}
             """
           end

lib/elixir/test/elixir/module/types/integration_test.exs

@@ -487,7 +487,9 @@ defmodule Module.Types.IntegrationTest do
 
                 -dynamic(%Range{})-
 
-            but expected a type that implements the String.Chars protocol, it must be one of:
+            but expected a type that implements the String.Chars protocol. You either passed the wrong value or you forgot to implement the protocol.
+
+            The String.Chars protocol is implemented for the following types:
 
                 dynamic(
                   %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or
@@ -511,7 +513,9 @@ defmodule Module.Types.IntegrationTest do
 
                 -dynamic(%Range{})-
 
-            but expected a type that implements the String.Chars protocol, it must be one of:
+            but expected a type that implements the String.Chars protocol. You either passed the wrong value or you forgot to implement the protocol.
+
+            The String.Chars protocol is implemented for the following types:
 
                 dynamic(
                   %Date{} or %DateTime{} or %NaiveDateTime{} or %Time{} or %URI{} or %Version{} or
@@ -551,7 +555,9 @@ defmodule Module.Types.IntegrationTest do
 
                 -dynamic(%Date{})-
 
-            but expected a type that implements the Enumerable protocol, it must be one of:
+            but expected a type that implements the Enumerable protocol. You either passed the wrong value or you forgot to implement the protocol.
+
+            The Enumerable protocol is implemented for the following types:
 
                 dynamic(
                   %Date.Range{} or %File.Stream{} or %GenEvent.Stream{} or %HashDict{} or %HashSet{} or
@@ -582,7 +588,9 @@ defmodule Module.Types.IntegrationTest do
 
                 -integer()-
 
-            but expected a type that implements the Collectable protocol, it must be one of:
+            but expected a type that implements the Collectable protocol. You either passed the wrong value or you forgot to implement the protocol.
+
+            The Collectable protocol is implemented for the following types:
 
                 dynamic(%File.Stream{} or %HashDict{} or %HashSet{} or %IO.Stream{} or %MapSet{}) or binary() or
                   empty_list() or non_empty_list(term(), term()) or non_struct_map()