Compile not ok dependencies on deps.get and deps.update

Author: José Valim

lib/mix/lib/mix/deps.ex

@@ -400,11 +400,16 @@ defmodule Mix.Deps do
     # deps if all dependencies are available. This is because if a
     # dependency is missing, it could be a children of the parent
     # (aka a sibling) which would make parent compilation fail.
+    #
+    # If there is any other dependency that is not ok, we include
+    # it for compilation too, this is our best to try to solve the
+    # maximum we can at each deps.get and deps.update.
     if Enum.all?(all_deps, &available?/1) do
-      deps = with_depending(deps, all_deps)
+      deps = with_depending(deps, all_deps) ++
+             Enum.filter(all_deps, fn dep -> not ok?(dep) end)
     end
 
-    apps = Enum.map(deps, &(&1.app))
+    apps = Enum.map(deps, &(&1.app)) |> Enum.uniq
     Mix.Deps.Lock.write(lock)
 
     unless opts[:no_compile] do
@@ -414,8 +419,11 @@ defmodule Mix.Deps do
       Mix.Task.run("deps.loadpaths", ["--no-deps-check"])
       Mix.Task.reenable("deps.loadpaths")
 
-      args = if opts[:quiet], do: ["--quiet"|apps], else: apps
-      Mix.Task.run("deps.compile", args)
+      if apps != [] do
+        args = if opts[:quiet], do: ["--quiet"|apps], else: apps
+        Mix.Task.run("deps.compile", args)
+      end
+
       unless opts[:no_deps_check] do
         Mix.Task.run("deps.check", [])
       end

lib/mix/test/mix/tasks/deps_test.exs

@@ -512,7 +512,7 @@ defmodule Mix.Tasks.DepsTest do
       File.write!("deps/ok/mix.exs", """)
       defmodule Ok.Mixfile do
         use Mix.Project
-        def project, do: [app: :ok]
+        def project, do: [app: :ok, version: "1.0.0"]
       end
       """
       File.write!("deps/ok/ebin/.compile.lock", "the_future")
@@ -524,6 +524,9 @@ defmodule Mix.Tasks.DepsTest do
 
       assert_received { :mix_shell, :error, ["* ok (deps/ok)"] }
       assert_received { :mix_shell, :error, ["  the dependency is built with an out-of-date elixir version, run `mix deps.get`"] }
+
+      Mix.Tasks.Deps.Get.run []
+      assert_received { :mix_shell, :info, ["* Compiling ok"] }
     end
   after
     Mix.Project.pop