Small improvements to records and others

Author: José Valim

lib/elixir/lib/record.ex

@@ -487,10 +487,10 @@ defmodule Record do
 
     case remaining do
       [] ->
-        quote do: { unquote_splicing([atom|match]) }
+        { :{}, [], [atom|match] }
       _  ->
         keys = lc { key, _ } inlist remaining, do: key
-        raise ArgumentError, message: "record #{inspect atom} does not have the keys: #{inspect keys}"
+        raise ArgumentError, message: "record #{inspect atom} does not have the key: #{inspect hd(keys)}"
     end
   end
 
@@ -713,7 +713,7 @@ defmodule Record do
     quote do
       @doc false
       def to_keywords(record) do
-        unquote(:orddict.from_list(sorted))
+        unquote(sorted)
       end
     end
   end
@@ -808,11 +808,11 @@ defmodule Record do
   end
 
   defp updater_lookup(k, key, values) do
-    v = find_index(values, key, 1)
+    index = find_index(values, key, 0)
 
     quote do
       case :lists.keyfind(unquote(k), 1, keywords) do
-        false -> elem(record, unquote(v))
+        false -> :erlang.element(unquote(index + 2), record)
         {_, value} -> value
       end
     end

lib/elixir/lib/string.ex

@@ -149,7 +149,7 @@ defmodule String do
   def printable?(<<?\a, t :: binary>>), do: printable?(t)
 
   def printable?(<<>>), do: true
-  def printable?(_),    do: false
+  def printable?(b) when is_binary(b), do: false
 
   @doc """
   Divides a string into substrings at each Unicode whitespace

lib/elixir/test/elixir/kernel/errors_test.exs

@@ -493,19 +493,13 @@ defmodule Kernel.ErrorsTest do
   end
 
   test :invalid_access_protocol_invalid_keywords do
-    assert_raise ArgumentError, "record Kernel.ErrorsTest.Config does not have the keys: [:foo]", fn ->
+    assert_raise ArgumentError, "record Kernel.ErrorsTest.Config does not have the key: :foo", fn ->
       defmodule ErrorsTest do
         def sample(Kernel.ErrorsTest.Config[foo: :bar]), do: true
       end
     end
   end
 
-  test :invalid_access_protocol_invalid_keywords_outside_match do
-    assert_compile_fail ArgumentError,
-      "record Kernel.ErrorsTest.Config does not have the keys: [:foo]",
-      'Kernel.ErrorsTest.Config[foo: :bar]'
-  end
-
   test :invalid_rescue_clause do
     assert_compile_fail CompileError,
       "nofile:4: invalid rescue clause. The clause should match on an alias, a variable or be in the `var in [alias]` format",

lib/iex/lib/iex/evaluator.ex

@@ -189,7 +189,7 @@ defmodule IEx.Evaluator do
   defp format_function(fun, arity) do
     cond do
       is_list(arity) ->
-        "#{fun}/#{Enum.count(arity)}"
+        "#{fun}/#{length(arity)}"
       true ->
         "#{fun}/#{arity}"
     end