Skip to content

Commit 1eda812

Browse files
author
José Valim
committed
Do not mark cases as loaded after failures, closes #4771
1 parent 2a1d3d6 commit 1eda812

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

lib/ex_unit/lib/ex_unit/server.ex

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,13 @@ defmodule ExUnit.Server do
5555
{:reply, diff, take_cases(%{state | loaded: :done})}
5656
end
5757

58-
def handle_cast({:add_async_case, name}, %{async_cases: cases} = state) do
58+
def handle_cast({:add_async_case, name}, %{async_cases: cases, loaded: loaded} = state)
59+
when is_integer(loaded) do
5960
{:noreply, take_cases(%{state | async_cases: [name | cases]})}
6061
end
6162

62-
def handle_cast({:add_sync_case, name}, %{sync_cases: cases} = state) do
63+
def handle_cast({:add_sync_case, name}, %{sync_cases: cases, loaded: loaded} = state)
64+
when is_integer(loaded) do
6365
{:noreply, %{state | sync_cases: [name | cases]}}
6466
end
6567

lib/mix/lib/mix/compilers/test.ex

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,8 @@ defmodule Mix.Compilers.Test do
4343
test_files ->
4444
try do
4545
task = Task.async(ExUnit, :run, [])
46-
47-
try do
48-
Kernel.ParallelRequire.files(test_files, parallel_require_callbacks)
49-
after
50-
ExUnit.Server.cases_loaded()
51-
end
52-
46+
Kernel.ParallelRequire.files(test_files, parallel_require_callbacks)
47+
ExUnit.Server.cases_loaded()
5348
%{failures: failures} = results = Task.await(task, :infinity)
5449

5550
if failures == 0 do

0 commit comments

Comments
 (0)