Save typespecs attributes with proper line numbers, closes #1613

Author: José Valim

lib/elixir/src/elixir_errors.erl

@@ -169,6 +169,10 @@ handle_file_error(File, {Line,erl_lint,{unsafe_var,Var,{In,_Where}}}) ->
   Message = io_lib:format("cannot define variable ~ts inside ~ts", [format_var(Var), Translated]),
   raise(Line, File, 'Elixir.CompileError', iolist_to_binary(Message));
 
+handle_file_error(File, {Line,erl_lint,{spec_fun_undefined,{M,F,A}}}) ->
+  Message = io_lib:format("spec for undefined function ~ts.~ts/~B", [inspect(M), F, A]),
+  raise(Line, File, 'Elixir.CompileError', iolist_to_binary(Message));
+
 handle_file_error(File, {Line,Module,Desc}) ->
   form_error(Line, File, Module, Desc).
 

lib/elixir/src/elixir_module.erl

@@ -68,7 +68,7 @@ compile(Line, Module, Block, Vars, #elixir_scope{context_modules=FileModules} =
     { Base, Export, Private, Def, Defmacro, Functions } = elixir_def:unwrap_stored_definitions(FileList, Module),
 
     { All, Forms0 } = functions_form(Line, File, Module, Base, Export, Def, Defmacro, Functions, C),
-    Forms1          = specs_form(Line, Module, Private, Defmacro, Forms0, C),
+    Forms1          = specs_form(Module, Private, Defmacro, Forms0, C),
     Forms2          = attributes_form(Line, File, Module, Forms1),
     Forms3          = typedocs_form(Module, Forms2),
 
@@ -213,7 +213,7 @@ typedocs_form(Module, Current) ->
 
 %% Specs
 
-specs_form(Line, Module, Private, Defmacro, Forms, C) ->
+specs_form(Module, Private, Defmacro, Forms, C) ->
   Defmacrop = [Tuple || { Tuple, defmacrop, _, _, _ } <- Private],
   case elixir_compiler:get_opt(internal, C) of
     true -> Forms;
@@ -225,16 +225,17 @@ specs_form(Line, Module, Private, Defmacro, Forms, C) ->
       'Elixir.Module':delete_attribute(Module, spec),
       'Elixir.Module':delete_attribute(Module, callback),
 
-      Temp = specs_attributes(Line, spec, Forms, Specs),
-      specs_attributes(Line, callback, Temp, Callbacks)
+      Temp = specs_attributes(spec, Forms, Specs),
+      specs_attributes(callback, Temp, Callbacks)
   end.
 
-specs_attributes(Line, Type, Forms, Specs) ->
+specs_attributes(Type, Forms, Specs) ->
   Keys = lists:foldl(fun({ Tuple, Value }, Acc) ->
-                       lists:keystore(Tuple, 1, Acc, { Tuple, Value } )
+                       lists:keystore(Tuple, 1, Acc, { Tuple, Value })
                      end, [], Specs),
   lists:foldl(fun({ Tuple, _ }, Acc) ->
     Values = [V || { K, V } <- Specs, K == Tuple],
+    { type, Line, _, _ } = hd(Values),
     [{ attribute, Line, Type, { Tuple, Values } }|Acc]
   end, Forms, Keys).
 

lib/elixir/test/elixir/kernel/errors_test.exs

@@ -575,6 +575,24 @@ defmodule Kernel.ErrorsTest do
       'case [] do; [] when Hello.something_that_does_not_exist == [] -> :ok; end'
   end
 
+  test :typespec_errors do
+    assert_compile_fail CompileError,
+      "nofile:2: type foo() undefined",
+      '''
+      defmodule Example do
+        @type omg :: foo
+      end
+      '''
+
+    assert_compile_fail CompileError,
+      "nofile:2: spec for undefined function Example.omg/0",
+      '''
+      defmodule Example do
+        @spec omg :: atom
+      end
+      '''
+  end
+
   test :macros_error_stacktrace do
     assert [{:erlang, :+, [1, :foo], _}, {ErrorsTest, :sample, 1, _}|_] =
       rescue_stacktrace(""")