Address tests on Erlang/OTP 26.1, closes #12975

Author: josevalim

lib/ex_unit/lib/ex_unit/callbacks.ex

@@ -549,14 +549,7 @@ defmodule ExUnit.Callbacks do
       end
 
     child_spec = Supervisor.child_spec(child_spec_or_module, opts)
-
-    case Supervisor.start_child(sup, child_spec) do
-      {:error, {:already_started, _pid}} ->
-        {:error, {:duplicate_child_name, child_spec.id}}
-
-      other ->
-        other
-    end
+    Supervisor.start_child(sup, child_spec)
   end
 
   @doc """

lib/ex_unit/test/ex_unit/formatter_test.exs

@@ -491,28 +491,25 @@ defmodule ExUnit.FormatterTest do
   test "inspect failure" do
     failure = [{:error, catch_assertion(assert :will_fail == %BadInspect{}), []}]
 
-    message = ~S'''
-      got FunctionClauseError with message:
-
-          """
-          no function clause matching in Inspect.ExUnit.FormatterTest.BadInspect.inspect/2
-          """
-
-      while inspecting:
-
-          %{__struct__: ExUnit.FormatterTest.BadInspect, key: 0}
-
-      Stacktrace:
-    '''
-
-    assert format_test_failure(test(), failure, 1, 80, &formatter/2) =~ """
+    assert format_test_failure(test(), failure, 1, 80, &formatter/2) =~ ~s'''
              1) world (Hello)
                 test/ex_unit/formatter_test.exs:1
                 Assertion with == failed
                 code:  assert :will_fail == %BadInspect{}
                 left:  :will_fail
-                right: #Inspect.Error<\n#{message}\
-           """
+                right: #Inspect.Error<
+             got FunctionClauseError with message:
+
+                 """
+                 no function clause matching in Inspect.ExUnit.FormatterTest.BadInspect.inspect/2
+                 """
+
+             while inspecting:
+
+                 #{inspect(%BadInspect{}, structs: false)}
+
+             Stacktrace:
+           '''
   end
 
   defmodule BadMessage do

lib/ex_unit/test/ex_unit/supervised_test.exs

@@ -73,19 +73,14 @@ defmodule ExUnit.SupervisedTest do
 
   test "starts a supervised process with ID checks" do
     {:ok, pid} = start_supervised({MyAgent, 0})
+    assert is_pid(pid)
 
-    assert {:error, {:duplicate_child_name, ExUnit.SupervisedTest.MyAgent}} =
-             start_supervised({MyAgent, 0})
-
-    assert {:error, {{:already_started, ^pid}, _}} = start_supervised({MyAgent, 0}, id: :another)
+    assert {:error, _} = start_supervised({MyAgent, 0})
+    assert {:error, _} = start_supervised({MyAgent, 0}, id: :another)
 
     assert_raise RuntimeError, ~r"Reason: bad child specification", fn ->
       start_supervised!(%{id: 1, start: :oops})
     end
-
-    assert_raise RuntimeError, ~r"Reason: already started", fn ->
-      start_supervised!({MyAgent, 0}, id: :another)
-    end
   end
 
   test "stops a supervised process" do