Ensure changes in child deps forces the parent to recompile

This test fell through the cracks when we changed mix
to no longer compile dependencies on get but during
project compilation.

Therefore, this patch fixes the bug and ensures the test
is up to date to check the original scenario it was supposed
to.

Signed-off-by: José Valim <jose.valim@plataformatec.com.br>

Author: José Valim

lib/mix/lib/mix/dep/fetcher.ex

@@ -133,7 +133,7 @@ defmodule Mix.Dep.Fetcher do
     dep_names = Enum.map(deps, fn dep -> dep.app end)
 
     parents = Enum.filter all_deps, fn dep ->
-      Enum.any?(dep.deps, &(&1 in dep_names))
+      Enum.any?(dep.deps, &(&1.app in dep_names))
     end
 
     do_with_depending(parents, all_deps) ++ parents

lib/mix/test/mix/tasks/deps.git_test.exs

@@ -100,7 +100,11 @@ defmodule Mix.Tasks.DepsGitTest do
       assert File.exists?("deps/git_repo/mix.exs")
       assert File.rm("deps/git_repo/.fetch") == :ok
 
-      Mix.Tasks.Deps.Update.run ["deps_on_git_repo"]
+      # Compile the dependencies
+      Mix.Tasks.Deps.Compile.run []
+
+      # Now update children and make sure it propagates
+      Mix.Tasks.Deps.Update.run ["git_repo"]
       assert File.exists?("deps/deps_on_git_repo/.fetch")
       assert File.exists?("deps/git_repo/.fetch")
 
@@ -109,7 +113,7 @@ defmodule Mix.Tasks.DepsGitTest do
       assert File.exists?("_build/dev/lib/git_repo/ebin")
       Code.delete_path("_build/dev/lib/git_repo/ebin")
 
-      # Deps on git repo loads it automatically on compile.
+      # Deps on git repo loads it automatically on compile
       Mix.Task.reenable "deps.loadpaths"
       Mix.Tasks.Deps.Compile.run ["deps_on_git_repo"]
       assert File.exists?("_build/dev/lib/deps_on_git_repo/ebin")