Skip to content

Commit 6c866e8

Browse files
committed
Fix type warnings in pop_in/1 (#14064)
1 parent 55eca5d commit 6c866e8

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

lib/elixir/lib/kernel.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3306,7 +3306,7 @@ defmodule Kernel do
33063306
end
33073307

33083308
defp nest_pop_in(:map, h, [{:access, key}]) do
3309-
quote do
3309+
quote generated: true do
33103310
case unquote(h) do
33113311
nil -> {nil, nil}
33123312
h -> Access.pop(h, unquote(key))
@@ -3327,7 +3327,7 @@ defmodule Kernel do
33273327
end
33283328

33293329
defp nest_pop_in(_, h, [{:access, key}]) do
3330-
quote do
3330+
quote generated: true do
33313331
case unquote(h) do
33323332
nil -> :pop
33333333
h -> Access.pop(h, unquote(key))

lib/elixir/test/elixir/kernel_test.exs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1136,6 +1136,8 @@ defmodule KernelTest do
11361136
test "pop_in/1" do
11371137
users = %{"john" => %{age: 27}, "meg" => %{age: 23}}
11381138

1139+
assert pop_in(users["john"]) == {%{age: 27}, %{"meg" => %{age: 23}}}
1140+
11391141
assert pop_in(users["john"][:age]) == {27, %{"john" => %{}, "meg" => %{age: 23}}}
11401142
assert pop_in(users["john"][:name]) == {nil, %{"john" => %{age: 27}, "meg" => %{age: 23}}}
11411143
assert pop_in(users["bob"][:age]) == {nil, %{"john" => %{age: 27}, "meg" => %{age: 23}}}

0 commit comments

Comments
 (0)