Ensure elixir_erl:debug_info/4 does not require elixir running (#6401)

Author: josevalim

.travis.yml

@@ -23,7 +23,14 @@ matrix:
     - os: linux
       otp_release: 20.0
 
-script: "make compile && rm -rf .git && make test"
+env:
+  - ELIXIR_ASSERT_TIMEOUT=2000
+
+script:
+  - make compile
+  - rm -rf .git
+  - make test
+  - dialyzer -pa lib/elixir/ebin --build_plt --output_plt elixir.plt --apps lib/elixir/ebin/elixir.beam lib/elixir/ebin/Elixir.Kernel.beam
 
 notifications:
   recipients:

lib/elixir/lib/module.ex

@@ -898,7 +898,7 @@ defmodule Module do
               "cannot make function #{function_name}/#{arity} overridable because it was not defined"
           clause ->
             neighbours =
-              if :elixir_compiler.get_opt(:internal) do
+              if :elixir_config.get(:bootstrap) do
                 []
               else
                 Module.LocalsTracker.yank(module, tuple)

lib/elixir/src/elixir.erl

@@ -102,8 +102,10 @@ start(_Type, _Args) ->
                    relative_paths => true},
   {ok, [[Home] | _]} = init:get_argument(home),
   Config = [{at_exit, []},
-            {home, unicode:characters_to_binary(Home, Encoding, Encoding)},
+            {argv, []},
+            {bootstrap, false},
             {compiler_options, CompilerOpts},
+            {home, unicode:characters_to_binary(Home, Encoding, Encoding)},
             {identifier_tokenizer, Tokenizer}
             | URIConfig],
   Tab = elixir_config:new(Config),

lib/elixir/src/elixir_aliases.erl

@@ -4,7 +4,7 @@
 -include("elixir.hrl").
 
 inspect(Atom) when is_atom(Atom) ->
-  case elixir_compiler:get_opt(internal) of
+  case elixir_config:get(bootstrap) of
     true  -> atom_to_binary(Atom, utf8);
     false -> 'Elixir.Inspect.Atom':inspect(Atom)
   end.

lib/elixir/src/elixir_compiler.erl

@@ -125,9 +125,9 @@ allows_fast_compilation(_) -> false.
 
 bootstrap() ->
   {ok, _} = application:ensure_all_started(elixir),
-  Update = fun(Old) -> maps:merge(Old, #{docs => false, internal => true,
-                                         relative_paths => false}) end,
+  Update = fun(Old) -> maps:merge(Old, #{docs => false, relative_paths => false}) end,
   _ = elixir_config:update(compiler_options, Update),
+  _ = elixir_config:put(bootstrap, true),
   [bootstrap_file(File) || File <- bootstrap_main()].
 
 bootstrap_file(File) ->

lib/elixir/src/elixir_erl.erl

@@ -153,7 +153,7 @@ compile(#{module := Module} = Map) ->
   Data = elixir_module:data_table(Module),
   {Prefix, Forms, Defmacro, Unreachable} = dynamic_form(Map),
   Specs =
-    case elixir_compiler:get_opt(internal) of
+    case elixir_config:get(bootstrap) of
       true -> [];
       false -> specs_form(Data, Defmacro, Unreachable, types_form(Data, []))
     end,

lib/elixir/src/elixir_erl_compiler.erl

@@ -58,7 +58,7 @@ handle_file_warning(_, _File, {_Line, erl_lint, {shadowed_var, _Var, _Where}}) -
 handle_file_warning(_, _File, {_Line, erl_lint, {exported_var, _Var, _Where}}) -> ok;
 
 handle_file_warning(_, File, {Line, erl_lint, {undefined_behaviour, Module}}) ->
-  case elixir_compiler:get_opt(internal) of
+  case elixir_config:get(bootstrap) of
     true ->
       ok;
     false ->

lib/elixir/src/elixir_lexical.erl

@@ -11,7 +11,7 @@
 -define(tracker, 'Elixir.Kernel.LexicalTracker').
 
 run(File, Dest, Callback) ->
-  case elixir_compiler:get_opt(internal) of
+  case elixir_config:get(bootstrap) of
     false ->
       {ok, Pid} = ?tracker:start_link(Dest),
       try Callback(Pid) of

lib/elixir/src/elixir_locals.erl

@@ -13,7 +13,7 @@
 -define(tracker, 'Elixir.Module.LocalsTracker').
 
 setup(Module) ->
-  case elixir_compiler:get_opt(internal) of
+  case elixir_config:get(bootstrap) of
     false ->
       {ok, Pid} = ?tracker:start_link(),
       ets:insert(elixir_module:data_table(Module), {?attr, Pid}),

lib/elixir/src/elixir_module.erl

@@ -86,7 +86,7 @@ compile(Line, Module, Block, Vars, E) ->
 
     {AllDefinitions, Unreachable} = elixir_def:fetch_definitions(File, Module),
 
-    (not elixir_compiler:get_opt(internal)) andalso
+    (not elixir_config:get(bootstrap)) andalso
      'Elixir.Module':check_behaviours_and_impls(E, Data, AllDefinitions, OverridablePairs),
 
     CompileOpts = lists:flatten(ets:lookup_element(Data, compile, 2)),
@@ -186,7 +186,7 @@ build(Line, File, Module, Lexical) ->
       end,
 
   ImplOnDefinition =
-      case elixir_compiler:get_opt(internal) of
+      case elixir_config:get(bootstrap) of
         true -> [{elixir_module, delete_impl}];
         _    -> [{'Elixir.Module', compile_impl}]
       end,