Add newline after inspection, closes #14819

Author: josevalim

lib/elixir/lib/exception.ex

@@ -188,13 +188,12 @@ defmodule Exception do
       term
       |> inspect(pretty: true)
       |> String.split("\n")
-      |> Enum.map(fn
+      |> Enum.map_intersperse("\n", fn
         "" -> ""
         line -> "    " <> line
       end)
-      |> Enum.join("\n")
 
-    message <> "\n\n" <> inspected
+    IO.iodata_to_binary([message, "\n\n", inspected, "\n"])
   end
 
   @doc """
@@ -1912,7 +1911,7 @@ defmodule UndefinedFunctionError do
   end
 
   defp format_fa({_dist, fun, arity}) do
-    ["      * ", Macro.inspect_atom(:remote_call, fun), ?/, Integer.to_string(arity), ?\n]
+    ["    * ", Macro.inspect_atom(:remote_call, fun), ?/, Integer.to_string(arity), ?\n]
   end
 
   defp exports_for(module) do
@@ -2244,7 +2243,7 @@ defmodule KeyError do
 
     case suggestions do
       [] -> []
-      suggestions -> ["\n\nDid you mean:\n\n" | format_suggestions(suggestions)]
+      suggestions -> ["\nDid you mean:\n\n" | format_suggestions(suggestions)]
     end
   end
 
@@ -2253,7 +2252,7 @@ defmodule KeyError do
     |> Enum.sort(&(elem(&1, 0) >= elem(&2, 0)))
     |> Enum.take(@max_suggestions)
     |> Enum.sort(&(elem(&1, 1) <= elem(&2, 1)))
-    |> Enum.map(fn {_, key} -> ["      * ", inspect(key), ?\n] end)
+    |> Enum.map(fn {_, key} -> ["    * ", inspect(key), ?\n] end)
   end
 end
 

lib/elixir/test/elixir/exception_test.exs

@@ -608,17 +608,17 @@ defmodule ExceptionTest do
       assert blame_message(Enum, & &1.map(:ok)) == """
              function Enum.map/1 is undefined or private. Did you mean:
 
-                   * map/2
+                 * map/2
              """
 
       assert blame_message(Enum, & &1.man(:ok)) == """
              function Enum.man/1 is undefined or private. Did you mean:
 
-                   * map/2
-                   * max/1
-                   * max/2
-                   * max/3
-                   * min/1
+                 * map/2
+                 * max/1
+                 * max/2
+                 * max/3
+                 * min/1
              """
 
       message = blame_message(:erlang, & &1.gt_cookie())
@@ -731,22 +731,23 @@ defmodule ExceptionTest do
     test "annotates key error with suggestions if keys are atoms" do
       message = blame_message(%{first: nil, second: nil}, fn map -> map.firts end)
 
-      assert message == """
-             key :firts not found in:
+      assert message ==
+               """
+               key :firts not found in:
 
-                 %{first: nil, second: nil}
+                   %{first: nil, second: nil}
 
-             Did you mean:
+               Did you mean:
 
                    * :first
-             """
+               """
 
       message = blame_message(%{"first" => nil, "second" => nil}, fn map -> map.firts end)
 
       assert message == """
              key :firts not found in:
 
-                 %{"first" => nil, "second" => nil}\
+                 %{"first" => nil, "second" => nil}
              """
 
       message =
@@ -756,7 +757,7 @@ defmodule ExceptionTest do
                """
                key "firts" not found in:
 
-                   %{"first" => nil, "second" => nil}\
+                   %{"first" => nil, "second" => nil}
                """
 
       message =
@@ -786,9 +787,9 @@ defmodule ExceptionTest do
 
              Did you mean:
 
-                   * :created_at
-                   * :finished_at
-                   * :started_at
+                 * :created_at
+                 * :finished_at
+                 * :started_at
              """
     end
 

lib/elixir/test/elixir/kernel/raise_test.exs

@@ -459,7 +459,7 @@ defmodule Kernel.RaiseTest do
                no match of right hand side value:
 
                    [1000000, 1000001, 1000002, 1000003, 1000004, 1000005, 1000006, 1000007,
-                    1000008, 1000009]\
+                    1000008, 1000009]
                """
     end
 
@@ -480,7 +480,7 @@ defmodule Kernel.RaiseTest do
           x in [KeyError] -> Exception.message(x)
         end
 
-      assert result == "key :foo not found in:\n\n    %{}"
+      assert result == "key :foo not found in:\n\n    %{}\n"
     end
 
     test "bad map error" do
@@ -491,7 +491,7 @@ defmodule Kernel.RaiseTest do
           x in [BadMapError] -> Exception.message(x)
         end
 
-      assert result == "expected a map, got:\n\n    0"
+      assert result == "expected a map, got:\n\n    0\n"
     end
 
     test "bad boolean error" do
@@ -502,7 +502,7 @@ defmodule Kernel.RaiseTest do
           x in [BadBooleanError] -> Exception.message(x)
         end
 
-      assert result == "expected a boolean on left-side of \"and\", got:\n\n    1"
+      assert result == "expected a boolean on left-side of \"and\", got:\n\n    1\n"
     end
 
     test "case clause error" do
@@ -517,7 +517,7 @@ defmodule Kernel.RaiseTest do
           x in [CaseClauseError] -> Exception.message(x)
         end
 
-      assert result == "no case clause matching:\n\n    0"
+      assert result == "no case clause matching:\n\n    0\n"
     end
 
     test "cond clause error" do
@@ -549,7 +549,7 @@ defmodule Kernel.RaiseTest do
           x in [TryClauseError] -> Exception.message(x)
         end
 
-      assert result == "no try clause matching:\n\n    :example"
+      assert result == "no try clause matching:\n\n    :example\n"
     end
 
     test "undefined function error as Erlang error" do

lib/elixir/test/elixir/kernel/with_test.exs

@@ -153,7 +153,7 @@ defmodule Kernel.WithTest do
   end
 
   test "else conditions with match error" do
-    assert_raise WithClauseError, "no with clause matching:\n\n    :error", fn ->
+    assert_raise WithClauseError, "no with clause matching:\n\n    :error\n", fn ->
       with({:ok, res} <- error(), do: res, else: ({:error, error} -> error))
     end
   end

lib/elixir/test/elixir/keyword_test.exs

@@ -70,11 +70,11 @@ defmodule KeywordTest do
     assert Keyword.replace!([a: 1, b: 2, a: 3, b: 4], :a, 1) == [a: 1, b: 2, b: 4]
     assert Keyword.replace!([a: 1, b: 2, c: 3, b: 4], :b, :new) == [a: 1, b: :new, c: 3]
 
-    assert_raise KeyError, "key :b not found in:\n\n    []", fn ->
+    assert_raise KeyError, "key :b not found in:\n\n    []\n", fn ->
       Keyword.replace!([], :b, :new)
     end
 
-    assert_raise KeyError, "key :c not found in:\n\n    [a: 1, b: 2, a: 3]", fn ->
+    assert_raise KeyError, "key :c not found in:\n\n    [a: 1, b: 2, a: 3]\n", fn ->
       Keyword.replace!([a: 1, b: 2, a: 3], :c, :new)
     end
   end

lib/elixir/test/elixir/map_test.exs

@@ -229,7 +229,7 @@ defmodule MapTest do
       Map.replace!(map, :x, 10)
     end
 
-    assert_raise KeyError, "key :x not found in:\n\n    %{}", fn ->
+    assert_raise KeyError, "key :x not found in:\n\n    %{}\n", fn ->
       Map.replace!(%{}, :x, 10)
     end
   end