Merge pull request #1829 from tonini/escape-underline-in-link-with-ansidoc

underlines within links have to be escaped

Author: José Valim

lib/iex/lib/iex/ansi_docs.ex

@@ -253,6 +253,21 @@ defmodule IEx.ANSIDocs do
   end
 
   defp handle_links(text) do
+    text
+    |> remove_square_brackets_in_link
+    |> escape_underlines_in_link
+  end
+
+  defp escape_underlines_in_link(text) do
+    case Regex.match?(%r{.*(https?\S*)}, text) do
+      true ->
+        Regex.replace(%r{_}, text, "\\\\_")
+      _ ->
+        text
+    end
+  end
+
+  defp remove_square_brackets_in_link(text) do
     Regex.replace(%r{\[(.*?)\]\((.*?)\)}, text, "\\1 (\\2)")
   end
 

lib/iex/test/iex/ansi_docs_test.exs

@@ -194,4 +194,11 @@ defmodule IEx.AnsiDocsTest do
     result = format("(`hello world`)")
     assert result == "(\e[36mhello world\e[0m)\n\e[0m"
   end
+
+  test "escaping of underlines within links" do
+    result = format("(http://en.wikipedia.org/wiki/ANSI_escape_code)")
+    assert result == "(http://en.wikipedia.org/wiki/ANSI_escape_code)\n\e[0m"
+    result = format("[ANSI escape code](http://en.wikipedia.org/wiki/ANSI_escape_code)")
+    assert result == "ANSI escape code (http://en.wikipedia.org/wiki/ANSI_escape_code)\n\e[0m"
+  end
 end