Support paths with white spaces in Windows releases (#9065)

Author: fertapric

lib/mix/lib/mix/tasks/release.init.ex

@@ -245,11 +245,11 @@ defmodule Mix.Tasks.Release.Init do
     popd
 
     if not defined RELEASE_NAME (set RELEASE_NAME=<%= @release.name %>)
-    if not defined RELEASE_VSN (for /f "tokens=1,2" %%K in (!RELEASE_ROOT!\releases\start_erl.data) do (set ERTS_VSN=%%K) && (set RELEASE_VSN=%%L))
+    if not defined RELEASE_VSN (for /f "tokens=1,2" %%K in ('type "!RELEASE_ROOT!\releases\start_erl.data"') do (set ERTS_VSN=%%K) && (set RELEASE_VSN=%%L))
     if not defined RELEASE_MODE (set RELEASE_MODE=embedded)
     set RELEASE_COMMAND=%~1
     set REL_VSN_DIR=!RELEASE_ROOT!\releases\!RELEASE_VSN!
-    call !REL_VSN_DIR!\env.bat
+    call "!REL_VSN_DIR!\env.bat"
 
     if not defined RELEASE_COOKIE (set /p RELEASE_COOKIE=<!RELEASE_ROOT!\releases\COOKIE)
     if not defined RELEASE_NODE (set RELEASE_NODE=!RELEASE_NAME!)

lib/mix/test/mix/tasks/release_test.exs

@@ -144,9 +144,10 @@ defmodule Mix.Tasks.ReleaseTest do
                } = wait_until_evaled(Path.join(root, "RELEASE_BOOTED"))
 
         if match?({:win32, _}, :os.type()) do
-          assert String.ends_with?(app_dir, "_build/dev/rel/RELEAS~1/lib/release_test-0.1.0")
-          assert String.ends_with?(release_root, "_build\\dev\\rel\\RELEAS~1")
-          assert String.ends_with?(root_dir, "_build/dev/rel/RELEAS~1")
+          # `RELEAS~1` is the DOS path name (8 character) for the `release_test` directory
+          assert app_dir =~ ~r"_build/dev/rel/(release_test|RELEAS~1)/lib/release_test-0\.1\.0$"
+          assert release_root =~ ~r"_build\\dev\\rel\\(release_test|RELEAS~1)$"
+          assert root_dir =~ ~r"_build/dev/rel/(release_test|RELEAS~1)$"
           assert String.ends_with?(sys_config_env, "releases\\0.1.0\\sys")
           assert String.ends_with?(sys_config_init, "releases\\0.1.0\\sys")
         else
@@ -285,7 +286,11 @@ defmodule Mix.Tasks.ReleaseTest do
   end
 
   test "runs eval and version commands" do
-    in_fixture("release_test", fn ->
+    # In some Windows setups (mostly with Docker), `System.cmd/3` fails because
+    # the path to the command/executable and one or more arguments contain spaces.
+    tmp_dir = Path.join(inspect(__MODULE__), "runs_eval_and_version_commands")
+
+    in_fixture("release_test", tmp_dir, fn ->
       config = [releases: [eval: [include_erts: false, cookie: "abcdefghij"]]]
 
       Mix.Project.in_project(:release_test, ".", config, fn _ ->
@@ -297,7 +302,7 @@ defmodule Mix.Tasks.ReleaseTest do
         assert String.trim_trailing(version) == "eval 0.1.0"
         refute File.exists?(Path.join(root, "RELEASE_BOOTED"))
 
-        {hello_world, 0} = System.cmd(script, ["eval", ~s[IO.puts :hello_world]])
+        {hello_world, 0} = System.cmd(script, ["eval", "IO.puts :hello_world"])
         assert String.trim_trailing(hello_world) == "hello_world"
         refute File.exists?(Path.join(root, "RELEASE_BOOTED"))