use ETF for elixir_scm and protocols manifests (#4779)

Author: ericentin

lib/mix/lib/mix/dep/elixir_scm.ex

@@ -10,18 +10,31 @@ defmodule Mix.Dep.ElixirSCM do
 
   def update(manifest_path \\ Mix.Project.manifest_path) do
     config = Mix.Project.config
-    data = {@manifest_vsn, System.version, config[:build_scm]}
     File.mkdir_p!(manifest_path)
-    File.write!(manifest(manifest_path), :io_lib.format('~p.~n', [data]))
-    :ok
+
+    manifest_data =
+      {@manifest_vsn, System.version, config[:build_scm]}
+      |> :erlang.term_to_binary(compressed: 9)
+
+    File.write!(manifest(manifest_path), manifest_data)
   end
 
   def read(manifest_path \\ Mix.Project.manifest_path) do
-    case :file.consult(manifest(manifest_path)) do
-      {:ok, [{@manifest_vsn, vsn, scm}]} ->
-        {:ok, vsn, scm}
-      {:error, {_, :erl_parse, _}} ->
-        {:ok, "1.0.0", nil} # Force old version if file exists but old format
+    case manifest(manifest_path) |> File.read() do
+      {:ok, contents} ->
+        try do
+           :erlang.binary_to_term(contents)
+        else
+          {@manifest_vsn, vsn, scm} ->
+            {:ok, vsn, scm}
+
+          _ ->
+            {:ok, "1.0.0", nil} # Force old version if file exists but old format
+        rescue
+          _ ->
+            {:ok, "1.0.0", nil} # Force old version if file exists but old format
+        end
+
       _ ->
         :error
     end

lib/mix/lib/mix/tasks/compile.protocols.ex

@@ -132,27 +132,28 @@ defmodule Mix.Tasks.Compile.Protocols do
   end
 
   defp read_manifest(manifest, output) do
-    case :file.consult(manifest) do
-      {:ok, [@manifest_vsn | t]} ->
+    try do
+      manifest |> File.read!() |> :erlang.binary_to_term()
+    else
+      [@manifest_vsn | t] ->
         t
-      {:ok, _} ->
+
+      _ ->
         # If manifest is out of date, remove old files
-        _ = File.rm_rf(output)
-        []
-      {:error, _} ->
+        File.rm_rf(output)
         []
+    rescue
+      _ -> []
     end
   end
 
   defp write_manifest(_manifest, nil), do: :om
   defp write_manifest(manifest, metadata) do
-    File.open!(manifest, [:write], fn device ->
-      :io.format(device, '~p.~n', [@manifest_vsn])
-      Enum.map metadata, fn entry ->
-        :io.format(device, '~p.~n', [entry])
-      end
-      :ok
-    end)
+    manifest_data =
+      [@manifest_vsn | metadata]
+      |> :erlang.term_to_binary(compressed: 9)
+
+    File.write!(manifest, manifest_data)
   end
 
   defp diff_manifest(manifest, new_metadata, output) do

lib/mix/test/mix/tasks/compile.elixir_test.exs

@@ -47,7 +47,8 @@ defmodule Mix.Tasks.Compile.ElixirTest do
 
       Mix.Task.clear
       File.write!("_build/dev/consolidated/.to_be_removed", "")
-      File.write!("_build/dev/lib/sample/.compile.elixir_scm", ~s({v1, <<"0.0.0">>, nil}.))
+      manifest_data = :erlang.term_to_binary({:v1, "0.0.0", nil})
+      File.write!("_build/dev/lib/sample/.compile.elixir_scm", manifest_data)
       File.touch!("_build/dev/lib/sample/.compile.elixir_scm", {{2010, 1, 1}, {0, 0, 0}})
 
       Mix.Tasks.Compile.run []
@@ -66,7 +67,8 @@ defmodule Mix.Tasks.Compile.ElixirTest do
       assert Mix.Dep.ElixirSCM.read == {:ok, System.version, Mix.SCM.Path}
 
       Mix.Task.clear
-      File.write!("_build/dev/lib/sample/.compile.elixir_scm", ~s({v1, <<"#{System.version}">>, another}.))
+      manifest_data = :erlang.term_to_binary({:v1, "#{System.version}", :another})
+      File.write!("_build/dev/lib/sample/.compile.elixir_scm", manifest_data)
       File.touch!("_build/dev/lib/sample/.compile.elixir_scm", {{2010, 1, 1}, {0, 0, 0}})
 
       Mix.Tasks.Compile.run []

lib/mix/test/mix/tasks/deps_test.exs

@@ -512,7 +512,8 @@ defmodule Mix.Tasks.DepsTest do
       Mix.Tasks.Deps.Check.run []
 
       File.mkdir_p!("_build/dev/lib/ok/ebin")
-      File.write!("_build/dev/lib/ok/.compile.elixir_scm", ~s({v1, <<\"the_future\">>, scm}.))
+      manifest_data = :erlang.term_to_binary({:v1, "the_future", :scm})
+      File.write!("_build/dev/lib/ok/.compile.elixir_scm", manifest_data)
       Mix.Task.clear
 
       msg = "  the dependency was built with an out-of-date Elixir version, run \"mix deps.compile\""
@@ -536,7 +537,8 @@ defmodule Mix.Tasks.DepsTest do
       Mix.Tasks.Deps.Check.run []
 
       File.mkdir_p!("_build/dev/lib/ok/ebin")
-      File.write!("_build/dev/lib/ok/.compile.elixir_scm", ~s({v1, <<"#{System.version}">>, scm}.))
+      manifest_data = :erlang.term_to_binary({:v1, "#{System.version}", :scm})
+      File.write!("_build/dev/lib/ok/.compile.elixir_scm", manifest_data)
       Mix.Task.clear
 
       msg = "  the dependency was built with another SCM, run \"mix deps.compile\""