Ensure Enum.to_list and Dict.to_list return exactly the same result

Author: José Valim

lib/elixir/lib/hash_dict.ex

@@ -227,7 +227,7 @@ defmodule HashDict do
   end
 
   def to_list(dict) do
-    dict_fold(dict, [], [&1|&2])
+    dict_fold(dict, [], [&1|&2]) |> :lists.reverse
   end
 
   @doc """
@@ -393,29 +393,25 @@ defmodule HashDict do
   end
 
   defp dict_equal?(dict1, dict2) do
-    fun = fn({ key, value }, acc) ->
-      case fetch(dict2, key) do
-        { _ok, ^value } ->
-          acc
-        { _ok, _other} ->
-          throw(:error)
-        :error ->
-          throw(:error)
-      end
-    end
     try do
-      reduce(dict1, true, fun)
+      reduce(dict1, true, fn({ key, value }, acc) ->
+        case fetch(dict2, key) do
+          { _ok, ^value } ->
+            acc
+          _ ->
+            throw(:error)
+        end
+      end)
     catch
-      :error ->
-        false
+      :error -> false
     end
   end
 
   ## Bucket helpers
 
   # Get value from the bucket
   defp bucket_get([{k,_}|_bucket], key) when k > key do
-    :false
+    false
   end
 
   defp bucket_get([{key,_}=e|_bucket], key) do
@@ -427,7 +423,7 @@ defmodule HashDict do
   end
 
   defp bucket_get([], _key) do
-    :false
+    false
   end
 
   # Puts a value in the bucket

lib/elixir/test/elixir/hash_dict_test.exs

@@ -111,13 +111,13 @@ defmodule HashDictTest do
     list = dict |> HashDict.to_list
     assert length(list) == 20
     assert { 1, 1 } in list
-    assert :lists.keysort(1, list) == :lists.keysort(1, Enum.to_list(dict))
+    assert list == Enum.to_list(dict)
 
     dict = filled_dict(120)
     list = dict |> HashDict.to_list
     assert length(list) == 120
     assert { 1, 1 } in list
-    assert :lists.keysort(1, list) == :lists.keysort(1, Enum.to_list(dict))
+    assert list == Enum.to_list(dict)
   end
 
   test :keys do