Remove IEx options from default args in ANSIDocs

Author: Thomaz Leite

lib/iex/lib/iex/ansi_docs.ex

@@ -6,7 +6,7 @@ defmodule IEx.ANSIDocs do
   @doc """
   Prints the head of the documentation (i.e. the function signature)
   """
-  def print_heading(string, use_ansi // IO.ANSI.terminal?, colors // IEx.Options.get(:colors)) do
+  def print_heading(string, use_ansi // IO.ANSI.terminal?, colors // []) do
     if use_ansi do
       write_doc_heading(string, colors)
     else
@@ -26,7 +26,7 @@ defmodule IEx.ANSIDocs do
   @doc """
   Prints the documentation body.
   """
-  def print(doc, use_ansi // IO.ANSI.terminal?, colors // IEx.Options.get(:colors)) do
+  def print(doc, use_ansi // IO.ANSI.terminal?, colors // []) do
     if use_ansi do
       doc
       |> String.split(["\r\n","\n"], trim: false)

lib/iex/lib/iex/introspection.ex

@@ -12,8 +12,10 @@ defmodule IEx.Introspection do
         if function_exported?(module, :__info__, 1) do
           case module.__info__(:moduledoc) do
             { _, binary } when is_binary(binary) ->
-              IEx.ANSIDocs.print_heading(inspect module)
-              IEx.ANSIDocs.print(binary)
+              use_ansi = IO.ANSI.terminal?
+              colors = IEx.Options.get(:colors)
+              IEx.ANSIDocs.print_heading(inspect(module), use_ansi, colors)
+              IEx.ANSIDocs.print(binary, use_ansi, colors)
             { _, _ } ->
               nodocs(inspect module)
             _ ->
@@ -158,8 +160,10 @@ defmodule IEx.Introspection do
 
   defp print_doc({ { fun, _ }, _line, kind, args, doc }) do
     args = Enum.map_join(args, ", ", &print_doc_arg(&1))
-    IEx.ANSIDocs.print_heading("#{kind} #{fun}(#{args})")
-    if doc, do: IEx.ANSIDocs.print(doc)
+    use_ansi = IO.ANSI.terminal?
+    colors = IEx.Options.get(:colors)
+    IEx.ANSIDocs.print_heading("#{kind} #{fun}(#{args})", use_ansi, colors)
+    if doc, do: IEx.ANSIDocs.print(doc, use_ansi, colors)
   end
 
   defp print_doc_arg({ ://, _, [left, right] }) do

lib/iex/test/iex/ansi_docs_test.exs

@@ -14,7 +14,7 @@ defmodule IEx.AnsiDocsTest do
   @opts [colors: @colors]
 
   def format(str, use_ansi // true) do
-    cmd = "IEx.ANSIDocs.print(#{inspect str}, #{inspect use_ansi})"
+    cmd = "IEx.ANSIDocs.print(#{inspect str}, #{inspect use_ansi}, #{inspect @colors})"
     capture_iex(cmd, @opts)
   end
 
@@ -23,7 +23,7 @@ defmodule IEx.AnsiDocsTest do
   end
 
   test "ansi heading is formatted" do
-    result = capture_iex("IEx.ANSIDocs.print_heading(\"wibble\", true)", @opts)
+    result = capture_iex("IEx.ANSIDocs.print_heading(\"wibble\", true, #{inspect @colors})", @opts)
     assert String.starts_with?(result, "\e[0m\n\e[7m\e[33m\e[1m")
     assert String.ends_with?(result, "\e[0m\n\e[0m")
     assert String.contains?(result, " wibble ")