Raise compile errors on bad record types

The record name must be an atom.

These checks were previously performed by erl_lint.

Author: fertapric

lib/elixir/lib/kernel/typespec.ex

@@ -568,11 +568,11 @@ defmodule Kernel.Typespec do
   end
 
   # Handle records
-  defp typespec({:record, meta, [atom]}, vars, caller, state) do
+  defp typespec({:record, meta, [atom]}, vars, caller, state) when is_atom(atom) do
     typespec({:record, meta, [atom, []]}, vars, caller, state)
   end
 
-  defp typespec({:record, meta, [tag, field_specs]}, vars, caller, state) do
+  defp typespec({:record, meta, [tag, field_specs]}, vars, caller, state) when is_atom(tag) do
     # We cannot set a function name to avoid tracking
     # as a compile time dependency because for records it actually is one.
     case Macro.expand({tag, [], [{:{}, [], []}]}, caller) do
@@ -595,6 +595,10 @@ defmodule Kernel.Typespec do
     end
   end
 
+  defp typespec({:record, _meta, _args}, _vars, caller, _state) do
+    compile_error(caller, "invalid record specification, expected the record name to be an atom")
+  end
+
   # Handle ranges
   defp typespec({:.., meta, [left, right]}, vars, caller, state) do
     {left, state} = typespec(left, vars, caller, state)

lib/elixir/test/elixir/typespec_test.exs

@@ -571,6 +571,14 @@ defmodule TypespecTest do
       end
     end
 
+    test "@type with invalid record" do
+      assert_raise CompileError, ~r"invalid record specification", fn ->
+        test_module do
+          @type my_type :: record(atom)
+        end
+      end
+    end
+
     test "@type with an invalid map notation" do
       assert_raise CompileError, ~r"invalid map specification", fn ->
         test_module do