Ensure Code.string_to_quoted input only needs the List.Chars protocol (#11344)

Author: michallepicki

lib/elixir/lib/code.ex

@@ -972,8 +972,7 @@ defmodule Code do
   @doc since: "1.13.0"
   @spec string_to_quoted_with_comments(List.Chars.t(), keyword) ::
           {:ok, Macro.t(), list(map())} | {:error, {location :: keyword, term, term}}
-  def string_to_quoted_with_comments(string, opts \\ [])
-      when is_binary(string) and is_list(opts) do
+  def string_to_quoted_with_comments(string, opts \\ []) when is_list(opts) do
     charlist = to_charlist(string)
     file = Keyword.get(opts, :file, "nofile")
     line = Keyword.get(opts, :line, 1)
@@ -1003,7 +1002,9 @@ defmodule Code do
   @doc since: "1.13.0"
   @spec string_to_quoted_with_comments!(List.Chars.t(), keyword) :: {Macro.t(), list(map())}
   def string_to_quoted_with_comments!(string, opts \\ []) do
-    case string_to_quoted_with_comments(string, opts) do
+    charlist = to_charlist(string)
+
+    case string_to_quoted_with_comments(charlist, opts) do
       {:ok, forms, comments} ->
         {forms, comments}
 
@@ -1013,7 +1014,7 @@ defmodule Code do
           Keyword.get(opts, :file, "nofile"),
           error,
           token,
-          {string, Keyword.get(opts, :line, 1), Keyword.get(opts, :column, 1)}
+          {charlist, Keyword.get(opts, :line, 1), Keyword.get(opts, :column, 1)}
         )
     end
   end

lib/elixir/test/elixir/code_test.exs

@@ -166,6 +166,13 @@ defmodule CodeTest do
     end
   end
 
+  test "string_to_quoted only requires the List.Chars protocol implementation to work" do
+    assert {:ok, 1.23} = Code.string_to_quoted(1.23)
+    assert 1.23 = Code.string_to_quoted!(1.23)
+    assert {:ok, 1.23, []} = Code.string_to_quoted_with_comments(1.23)
+    assert {1.23, []} = Code.string_to_quoted_with_comments!(1.23)
+  end
+
   test "compile source" do
     assert __MODULE__.__info__(:compile)[:source] == String.to_charlist(__ENV__.file)
   end