Raise on unknown dependencies for deps.get and deps.update

Author: José Valim

lib/mix/lib/mix/deps.ex

@@ -120,9 +120,10 @@ defmodule Mix.Deps do
 
     # Now we validate the given atoms
     index = Mix.Dep.__record__(:index, :app)
+
     Enum.each apps, fn(app) ->
-      unless List.keyfind(deps, app, index) do
-        Mix.shell.info "unknown dependency #{app} for env #{Mix.env}"
+      unless List.keyfind(all_deps, app, index) do
+        raise Mix.Error, message: "unknown dependency #{app} for environment #{Mix.env}"
       end
     end
 

lib/mix/lib/mix/deps/fetcher.ex

@@ -13,14 +13,17 @@ defmodule Mix.Deps.Fetcher do
   Fetches all dependencies.
   """
   def all(old_lock, new_lock, opts) do
-    do_finalize Mix.Deps.unloaded({ [], new_lock }, &do_fetch/2), old_lock, opts
+    { apps, _deps } = do_finalize Mix.Deps.unloaded({ [], new_lock }, &do_fetch/2), old_lock, opts
+    apps
   end
 
   @doc """
   Fetches the dependencies with the given names and their children recursively.
   """
   def by_name(names, old_lock, new_lock, opts) do
-    do_finalize Mix.Deps.unloaded_by_name(names, { [], new_lock }, &do_fetch/2), old_lock, opts
+    { apps, deps } = do_finalize Mix.Deps.unloaded_by_name(names, { [], new_lock }, &do_fetch/2), old_lock, opts
+    Mix.Deps.loaded_by_name(names, deps) # Check all given dependencies are loaded or fail
+    apps
   end
 
   defp do_fetch(dep, { acc, lock }) do
@@ -81,7 +84,7 @@ defmodule Mix.Deps.Fetcher do
     Mix.Deps.Lock.write(lock)
 
     do_compile(deps, opts)
-    apps
+    { apps, all_deps }
   end
 
   defp do_compile(deps, opts) do

lib/mix/test/mix/tasks/deps_test.exs

@@ -199,7 +199,7 @@ defmodule Mix.Tasks.DepsTest do
     end
   end
 
-  test "does not choke when another environment is compiled first than dep" do
+  test "does not choke when another environment is compiled first than dev" do
     Mix.Project.push PerEnvironemtDepsApp
     Mix.env(:test)
 
@@ -365,6 +365,16 @@ defmodule Mix.Tasks.DepsTest do
     end
   end
 
+  test "fails on missing dependencies" do
+    Mix.Project.push SuccessfulDepsApp
+
+    in_fixture "deps_status", fn ->
+      assert_raise Mix.Error, %r/unknown dependency invalid for environment dev/, fn ->
+        Mix.Tasks.Deps.Get.run ["invalid"]
+      end
+    end
+  end
+
   test "works with nested dependencies" do
     Mix.Project.push NestedDepsApp