Skip to content

Commit 68d5c8e

Browse files
committed
Fix #524: Change test for issue 443 to handle changed comment delimiter in emacs 27
1 parent 2fc5562 commit 68d5c8e

File tree

2 files changed

+81
-1
lines changed

2 files changed

+81
-1
lines changed

php-mode-test.el

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,8 @@ style from Drupal."
930930
(ert-deftest php-mode-test-issue-443 ()
931931
"This case allows you to color things that are not authentic PHP tags
932932
(ex. `<?xml', `<?hh') as false positives."
933-
(with-php-mode-test ("issue-443.php" :faces t)))
933+
(with-php-mode-test ("issue-443.php"
934+
:faces (if (version<= "27" emacs-version) ".27.faces" t))))
934935

935936
(ert-deftest php-mode-test-type-hints ()
936937
"Test highlighting of type hints and return types."

tests/issue-443.php.27.faces

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,79 @@
1+
;; -*- mode: emacs-lisp -*-
2+
(("<?php" . php-php-tag)
3+
(" ")
4+
("declare" . php-keyword)
5+
("(")
6+
("strict_types" . php-keyword)
7+
("=1); ")
8+
("?>" . php-php-tag)
9+
("\n")
10+
("/** GitHub Issue: " . font-lock-doc-face)
11+
("https://github.com/emacs-php/php-mode/issues/443" link font-lock-doc-face)
12+
(" */" . font-lock-doc-face)
13+
("\n")
14+
("<?xml" . php-php-tag)
15+
(" version=")
16+
("\"1.0\"" . php-string)
17+
(" ")
18+
("encoding" . php-keyword)
19+
("=")
20+
("\"UTF-8\"" . php-string)
21+
("?>" . php-php-tag)
22+
("\n")
23+
("<?hh" . php-php-tag)
24+
(" ")
25+
("echo" . php-keyword)
26+
(" ")
27+
("\"Hack open tag\"" . php-string)
28+
(" ")
29+
("?>" . php-php-tag)
30+
("\n")
31+
("<?" . php-php-tag)
32+
(" ")
33+
("echo" . php-keyword)
34+
(" ")
35+
("\"obsolete short open tag\"" . php-string)
36+
(" ")
37+
("?>" . php-php-tag)
38+
("\n")
39+
("<%" . php-php-tag)
40+
(" ")
41+
("echo" . php-keyword)
42+
(" ")
43+
("\"obsolete ASP tags\"" . php-string)
44+
(" ")
45+
("%>" . php-php-tag)
46+
("\n")
47+
("<?=" . php-php-tag)
48+
(" ")
49+
("\"foo\"" . php-string)
50+
(" ")
51+
("?>" . php-php-tag)
52+
("\n")
53+
("<?=" . php-php-tag)
54+
(" 1 + 1 ")
55+
("?>" . php-php-tag)
56+
("\n")
57+
("<?php" . php-php-tag)
58+
(" ")
59+
("/* " . font-lock-comment-delimiter-face)
60+
("Foo" . font-lock-comment-face)
61+
(" */" . font-lock-comment-delimiter-face)
62+
(" ")
63+
("echo" . php-keyword)
64+
(" ")
65+
("\"Bar\"" . php-string)
66+
("; ")
67+
("?>" . php-php-tag)
68+
("\n")
69+
("<?php" . php-php-tag)
70+
("/* " . font-lock-comment-delimiter-face)
71+
("Foo" . font-lock-comment-face)
72+
(" */" . font-lock-comment-delimiter-face)
73+
(" ")
74+
("echo" . php-keyword)
75+
(" ")
76+
("\"Bar\"" . php-string)
77+
("; ")
78+
("?>" . php-php-tag)
79+
("\n"))

0 commit comments

Comments
 (0)