Skip to content

Commit e96df88

Browse files
authored
Merge pull request #428 from zonuexe/feature/remove-require-final-newline
Remove set require-final-newline variable from c-add-style clause
2 parents e9e1b58 + b4ad97d commit e96df88

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

php-mode.el

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,6 @@ but only if the setting is enabled"
682682
(indent-tabs-mode . nil)
683683
(tab-width . ,(default-value 'tab-width))
684684
(fill-column . ,(default-value 'fill-column))
685-
(require-final-newline . ,(default-value 'require-final-newline))
686685
(show-trailing-whitespace . ,(default-value 'show-trailing-whitespace))
687686
(php-style-delete-trailing-whitespace . nil)))
688687

@@ -736,8 +735,7 @@ but only if the setting is enabled"
736735
'("php"
737736
(c-offsets-alist . ((statement-cont . php-lineup-hanging-semicolon)))
738737
(c-indent-comments-syntactically-p . t)
739-
(fill-column . 78)
740-
(require-final-newline . t)))
738+
(fill-column . 78)))
741739

742740
(defun php-enable-symfony2-coding-style ()
743741
"Make php-mode use coding styles that are preferable for working with Symfony2."
@@ -750,7 +748,6 @@ but only if the setting is enabled"
750748
(c-offsets-alist . ((statement-cont . +)))
751749
(c-indent-comments-syntactically-p . t)
752750
(fill-column . 78)
753-
(require-final-newline . t)
754751
(show-trailing-whitespace . t)
755752
(php-style-delete-trailing-whitespace . t)))
756753

@@ -1203,12 +1200,6 @@ After setting the stylevars run hooks according to STYLENAME
12031200
;; PHP vars are case-sensitive
12041201
(setq case-fold-search t)
12051202

1206-
;; Do not force newline at end of file. Such newlines can cause
1207-
;; trouble if the PHP file is included in another file before calls
1208-
;; to header() or cookie().
1209-
(set (make-local-variable 'require-final-newline) nil)
1210-
(set (make-local-variable 'next-line-add-newlines) nil)
1211-
12121203
(php-set-style (symbol-name php-mode-coding-style))
12131204

12141205
(when (or php-mode-force-pear

0 commit comments

Comments
 (0)