Merge pull request #39 from emacs-php/fix/flycheck-phpstan-executable

Use phpstan-get-executable instead of makeshift processing

Author: zonuexe

flycheck-phpstan.el

@@ -49,20 +49,15 @@
   (let ((enabled (phpstan-enabled)))
     (prog1 enabled
       (when (and phpstan-flycheck-auto-set-executable
-                 (not (and (boundp 'flycheck-phpstan-executable)
-                           (symbol-value 'flycheck-phpstan-executable)))
+                 (null (bound-and-true-p flycheck-phpstan-executable))
                  (or (stringp phpstan-executable)
                      (eq 'docker phpstan-executable)
                      (and (eq 'root (car-safe phpstan-executable))
                           (stringp (cdr-safe phpstan-executable)))
                      (and (stringp (car-safe phpstan-executable))
                           (listp (cdr-safe phpstan-executable)))
                      (null phpstan-executable)))
-        (set (make-local-variable 'flycheck-phpstan-executable)
-             (cond
-              ((eq 'docker phpstan-executable) phpstan-docker-executable)
-              ((stringp phpstan-executable) phpstan-executable)
-              (t (car phpstan-executable))))))))
+        (setq-local flycheck-phpstan-executable (nth 0 (phpstan-get-executable)))))))
 
 (flycheck-define-checker phpstan
   "PHP static analyzer based on PHPStan."