#36: Fix validation of column names for variadic UDFs (#37)

Author: tkilias

exasol_udf_mock_python/mock_meta_data.py

@@ -14,27 +14,27 @@ def __init__(
             output_columns: List[Column],
             output_type: str,
             is_variadic_input: bool = False,
-            script_name: str="TEST_UDF",
-            script_schema: str="TEST_SCHEMA",
-            current_user: str="sys",
-            current_schema: str="TEST_SCHEMA",
-            scope_user: str="sys",
-            connection_id: str="123123",
-            database_name: str="TEST_DB",
-            database_version: str="7.0.0",
-            node_count: int="1",
-            node_id: int="0",
-            vm_id: int="123",
-            session_id: int="123456789",
-            statement_id: int="123456789",
-            memory_limit: int=4*1073741824,
-            ):
+            script_name: str = "TEST_UDF",
+            script_schema: str = "TEST_SCHEMA",
+            current_user: str = "sys",
+            current_schema: str = "TEST_SCHEMA",
+            scope_user: str = "sys",
+            connection_id: str = "123123",
+            database_name: str = "TEST_DB",
+            database_version: str = "7.0.0",
+            node_count: int = "1",
+            node_id: int = "0",
+            vm_id: int = "123",
+            session_id: int = "123456789",
+            statement_id: int = "123456789",
+            memory_limit: int = 4 * 1073741824,
+    ):
 
         assert input_type.upper() in ["SET", "SCALAR"]
         assert output_type.upper() in ["EMITS", "RETURNS"]
         if is_variadic_input:
-            for i in range(len(input_columns)):
-                assert str(i+1) == str(input_columns[i].name)
+            assert all([str(i) == str(column.name)
+                        for i, column in enumerate(input_columns)])
 
         self._script_language = "PYTHON3"
         self._script_name = script_name

tests/test_executor_context_set_emits.py

@@ -378,9 +378,9 @@ def run(ctx):
             ctx.emit(ctx[1])
             ctx.emit(ctx["2"])
 
-    input_columns = [Column("1", int, "INTEGER"),
-                     Column("2", int, "INTEGER"),
-                     Column("3", int, "INTEGER")]
+    input_columns = [Column("0", int, "INTEGER"),
+                     Column("1", int, "INTEGER"),
+                     Column("2", int, "INTEGER")]
     output_columns = [Column("o1", int, "INTEGER")]
     meta = MockMetaData(
         script_code_wrapper_function=udf_wrapper,
@@ -443,19 +443,15 @@ def run(ctx):
 
         input_columns = [Column("1", int, "INTEGER")]
         output_columns = [Column("o1", int, "INTEGER")]
-        meta = MockMetaData(
-            script_code_wrapper_function=udf_wrapper,
-            input_type="SET",
-            input_columns=input_columns,
-            output_type="EMITS",
-            output_columns=output_columns,
-            is_variadic_input=True)
-
-        input_data = [(1,)]
-        exa = MockExaEnvironment(meta)
-        executor = UDFMockExecutor()
-        with self.assertRaises(RuntimeError):
-            result = executor.run([Group(input_data)], exa)
+        with self.assertRaises(AssertionError):
+            meta = MockMetaData(
+                script_code_wrapper_function=udf_wrapper,
+                input_type="SET",
+                input_columns=input_columns,
+                output_type="EMITS",
+                output_columns=output_columns,
+                is_variadic_input=True)
+
 
     def test_invalid_variadic_input_columns_name(self):
         def udf_wrapper():