Skip to content

Commit 06f1c0e

Browse files
committed
Fixed naming issues of fields
1 parent eee9d64 commit 06f1c0e

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

library/src/main/java/com/firebase/ui/FirebaseLoginBaseActivity.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.firebase.ui;
22

33
import android.os.Bundle;
4-
import android.os.PersistableBundle;
54
import android.support.v7.app.AppCompatActivity;
6-
import android.util.Log;
75

86
import com.firebase.client.AuthData;
97
import com.firebase.client.Firebase;
@@ -22,11 +20,11 @@ public abstract class FirebaseLoginBaseActivity extends AppCompatActivity {
2220

2321
private final String LOG_TAG = "FirebaseLoginBaseAct";
2422

25-
public Firebase ref;
23+
private Firebase mRef;
2624

2725
private GoogleAuthHelper mGoogleAuthHelper;
2826

29-
public SocialProvider chosenProvider;
27+
public SocialProvider mChosenProvider;
3028

3129
/* Abstract methods for Login Events */
3230
public abstract void onFirebaseLogin(AuthData authData);
@@ -52,11 +50,11 @@ public void loginWithProvider(SocialProvider provider) {
5250
break;
5351
}
5452

55-
chosenProvider = provider;
53+
mChosenProvider = provider;
5654
}
5755

5856
public void logout() {
59-
switch (chosenProvider) {
57+
switch (mChosenProvider) {
6058
case Google:
6159
mGoogleAuthHelper.logout();
6260
break;
@@ -65,7 +63,7 @@ public void logout() {
6563
case Twitter:
6664
break;
6765
}
68-
ref.unauth();
66+
mRef.unauth();
6967
}
7068

7169

@@ -74,7 +72,7 @@ public void onCreate(Bundle savedInstanceState) {
7472
super.onCreate(savedInstanceState);
7573
Firebase.setAndroidContext(this);
7674

77-
ref = setupFirebase();
75+
mRef = setupFirebase();
7876

7977
mGoogleAuthHelper = new GoogleAuthHelper(this, new TokenAuthHandler() {
8078
@Override
@@ -97,7 +95,7 @@ public void onError(Exception ex) {
9795
@Override
9896
protected void onStart() {
9997
super.onStart();
100-
ref.addAuthStateListener(new Firebase.AuthStateListener() {
98+
mRef.addAuthStateListener(new Firebase.AuthStateListener() {
10199
@Override
102100
public void onAuthStateChanged(AuthData authData) {
103101
if (authData != null) {
@@ -110,10 +108,10 @@ public void onAuthStateChanged(AuthData authData) {
110108
}
111109

112110
private void authenticateRefWithProvider(String provider, String token) {
113-
ref.authWithOAuthToken(provider, token, new Firebase.AuthResultHandler() {
111+
mRef.authWithOAuthToken(provider, token, new Firebase.AuthResultHandler() {
114112
@Override
115113
public void onAuthenticated(AuthData authData) {
116-
// Do nothing. Auth updates are handled in the AuthStateListener
114+
// Do nothing. Auth updates are handled in the AuthStateListener
117115
}
118116

119117
@Override

0 commit comments

Comments
 (0)