No longer pass client ID into Google API Client

Fixes #41
Also raise error is sign-in result is not a success.

Author: puf

app/src/main/AndroidManifest.xml

@@ -39,12 +39,6 @@
             android:name="com.facebook.sdk.ApplicationId"
             android:value="@string/facebook_app_id" />
 
-        <!-- Google Configuration -->
-        <meta-data
-            android:name="com.firebase.ui.GoogleClientId"
-            android:value="@string/google_client_id" />
-
-
     </application>
 
 </manifest>

library/src/main/java/com/firebase/ui/auth/google/GoogleAuthProvider.java

@@ -3,8 +3,6 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
-import android.content.pm.ApplicationInfo;
-import android.content.pm.PackageManager;
 import android.os.Bundle;
 import android.support.v4.app.FragmentActivity;
 import android.util.Log;
@@ -44,33 +42,7 @@ public GoogleAuthProvider(Context context, Firebase ref, TokenAuthHandler handle
         mRef = ref;
         mHandler = handler;
 
-        String googleClientId = "";
-
-        try {
-            ApplicationInfo ai = mActivity.getPackageManager().getApplicationInfo(mActivity.getPackageName(), PackageManager.GET_META_DATA);
-            Bundle bundle = ai.metaData;
-            googleClientId = bundle.getString("com.firebase.ui.GoogleClientId");
-        } catch (PackageManager.NameNotFoundException e) {
-        } catch (NullPointerException e) {}
-
-        if (googleClientId == null) {
-            FirebaseLoginError error = new FirebaseLoginError(
-                    FirebaseResponse.MISSING_PROVIDER_APP_KEY,
-                    "Missing Google client ID, is it set in your AndroidManifest.xml?");
-            mHandler.onProviderError(error);
-            return;
-        }
-
-        if (googleClientId.compareTo("") == 0) {
-            FirebaseLoginError error = new FirebaseLoginError(
-                    FirebaseResponse.INVALID_PROVIDER_APP_KEY,
-                    "Invalid Google client ID, is it set in your res/values/strings.xml?");
-            mHandler.onProviderError(error);
-            return;
-        }
-
         GoogleSignInOptions gso = new GoogleSignInOptions.Builder(GoogleSignInOptions.DEFAULT_SIGN_IN)
-                .requestIdToken(googleClientId)
                 .requestEmail()
                 .build();
 
@@ -99,7 +71,9 @@ public void onConnected(Bundle bundle) {
     }
 
     @Override
-    public void onConnectionSuspended(int i) {}
+    public void onConnectionSuspended(int i) {
+
+    }
 
     public void logout() {
         if (mGoogleApiClient.isConnected()) {
@@ -154,6 +128,9 @@ private void handleSignInResult(GoogleSignInResult result) {
             googleOAuthTask.setHandler(this);
             googleOAuthTask.execute(acct.getEmail());
         }
+        else {
+            mHandler.onProviderError(new FirebaseLoginError(FirebaseResponse.MISC_PROVIDER_ERROR, result.getStatus().toString()));
+        }
     }