Use Firebase BOM (#1752)

Author: samtstern

app/build.gradle.kts

@@ -32,7 +32,6 @@ android {
 }
 
 dependencies {
-    implementation(Config.Libs.Firebase.core)
     implementation(Config.Libs.Androidx.design)
     implementation(Config.Libs.Androidx.multidex)
 

auth/build.gradle.kts

@@ -34,6 +34,7 @@ dependencies {
     implementation(Config.Libs.Androidx.lifecycleExtensions)
     annotationProcessor(Config.Libs.Androidx.lifecycleCompiler)
 
+    implementation(platform(Config.Libs.Firebase.bom))
     api(Config.Libs.Firebase.auth)
     api(Config.Libs.PlayServices.auth)
 

build.gradle.kts

@@ -29,8 +29,8 @@ plugins {
 }
 
 buildScan {
-    setTermsOfServiceUrl("https://gradle.com/terms-of-service")
-    setTermsOfServiceAgree("yes")
+    termsOfServiceUrl = "https://gradle.com/terms-of-service"
+    termsOfServiceAgree = "yes"
 }
 
 // See https://github.com/gradle/kotlin-dsl/issues/607#issuecomment-375687119
@@ -110,8 +110,8 @@ fun Project.configureAndroid() {
             isAbortOnError = true
 
             baselineFile = file("$configDir/lint-baseline.xml")
-            htmlOutput = file("$reportsDir/lint-results.html")
-            xmlOutput = file("$reportsDir/lint-results.xml")
+            // htmlOutput = file("$reportsDir/lint-results.html")
+            // xmlOutput = file("$reportsDir/lint-results.xml")
         }
     }
 }
@@ -298,22 +298,34 @@ fun Project.setupPublishing() {
 
                     withXml {
                         asNode().appendNode("dependencies").apply {
-                            fun Dependency.write(scope: String) = appendNode("dependency").apply {
-                                appendNode("groupId", group)
-                                appendNode("artifactId", if (group == groupName) {
-                                    "firebase-ui-$name"
+                            fun ResolvedDependency.write(scope: String) = appendNode("dependency").apply {
+                                val publicArtifactId = if (moduleGroup == groupName) {
+                                    "firebase-ui-$moduleName"
                                 } else {
-                                    name
-                                })
-                                appendNode("version", version)
+                                    moduleName
+                                }
+                                appendNode("groupId", moduleGroup)
+                                appendNode("artifactId", publicArtifactId)
+                                appendNode("version", moduleVersion)
                                 appendNode("scope", scope)
                             }
 
-                            for (dependency in configurations["api"].dependencies) {
-                                dependency.write("compile")
+                            val apiDependencyNames = configurations["api"].dependencies.map {
+                                it.name
                             }
-                            for (dependency in configurations["implementation"].dependencies) {
-                                dependency.write("runtime")
+
+                            val implementationDependencyNames = configurations["implementation"].dependencies.map {
+                                it.name
+                            }
+
+                            configurations["releaseCompileClasspath"].resolvedConfiguration.firstLevelModuleDependencies.forEach {
+                                if (apiDependencyNames.contains(it.moduleName)) {
+                                    it.write("compile")
+                                }
+
+                                if (implementationDependencyNames.contains(it.moduleName)) {
+                                    it.write("runtime")
+                                }
                             }
                         }
                     }

buildSrc/src/main/kotlin/Config.kt

@@ -43,11 +43,11 @@ object Config {
         }
 
         object Firebase {
-            const val auth = "com.google.firebase:firebase-auth:19.2.0"
-            const val core = "com.google.firebase:firebase-core:17.2.1"
-            const val database = "com.google.firebase:firebase-database:19.2.0"
-            const val firestore = "com.google.firebase:firebase-firestore:21.3.1"
-            const val storage = "com.google.firebase:firebase-storage:19.1.0"
+            const val bom = "com.google.firebase:firebase-bom:25.1.0"
+            const val auth = "com.google.firebase:firebase-auth"
+            const val database = "com.google.firebase:firebase-database"
+            const val firestore = "com.google.firebase:firebase-firestore"
+            const val storage = "com.google.firebase:firebase-storage"
         }
 
         object PlayServices {

database/build.gradle.kts

@@ -14,6 +14,7 @@ android {
 }
 
 dependencies {
+    implementation(platform(Config.Libs.Firebase.bom))
     api(project(":common"))
     api(Config.Libs.Firebase.database)
 

firestore/build.gradle.kts

@@ -15,6 +15,7 @@ android {
 }
 
 dependencies {
+    implementation(platform(Config.Libs.Firebase.bom))
     api(project(":common"))
     api(Config.Libs.Firebase.firestore)
 

proguard-tests/build.gradle.kts

@@ -38,7 +38,6 @@ dependencies {
     implementation(project(":database"))
     implementation(project(":storage"))
 
-    implementation(Config.Libs.Firebase.core)
     implementation(Config.Libs.Androidx.lifecycleExtensions)
 }
 

storage/build.gradle.kts

@@ -10,6 +10,7 @@ android {
 dependencies {
     api(Config.Libs.Misc.glide)
 
+    implementation(platform(Config.Libs.Firebase.bom))
     api(Config.Libs.Firebase.storage)
     // Override Play Services
     implementation(Config.Libs.Androidx.legacySupportv4)