boringSSL clone specific commit (#485)

Clone the boringSSL sources to a specific commit, instead of cloning the repo first and then checking out a commit.

This frees up enough disk space that we no longer need to copy the resulting artifacts over to the C drive on Windows hosts in order to make enough room for the google cloud sdk installation. Therefore I've removed that step from the CI saving up to 20 minutes per windows integration test build.

Author: DellaBitta

.github/workflows/integration_tests.yml

@@ -326,35 +326,6 @@ jobs:
         shell: bash
         run: |
           rm -rf testapps-desktop-${{ matrix.os }}-${{ matrix.ssl_variant }}
-      - name: Configure GCS Upload Directory (Linux, macOS)
-        if: (startsWith(matrix.os, 'ubuntu') || startsWith(matrix.os, 'macos')) && !cancelled()
-        shell: bash
-        run: echo "GCS_UPLOAD_DIR=${{ github.workspace }}" >> $GITHUB_ENV
-      - name: Configure GCS Upload Directory (Windows)
-        # For Windows move the uploads to C: to create enough space for the
-        # Cloud SDK installation on D:.
-        if: startsWith(matrix.os, 'windows') && !cancelled()
-        shell: bash
-        run: echo "GCS_UPLOAD_DIR=/c/fpl-upload" >> $GITHUB_ENV
-      - name: Move GCS Artifacts to GCS Upload Dir
-        # Copy the artifacts and also the upload scripts since python's relpath
-        # produces errors when called across two different drives. Use tar to
-        # move the files as it neatly deepcopies firestore's symlinks.
-        if:  ${{ (env.GCS_UPLOAD_DIR != github.workspace) && !cancelled() }}
-        shell: bash
-        run: |
-          set -x
-          mkdir -p ${{env.GCS_UPLOAD_DIR}}/scripts/gha/integration_testing
-          mkdir -p ${{env.GCS_UPLOAD_DIR}}/scripts/gha-encrypted
-          # The ta directory contains the integration testapps to archive.
-          tar -chf ${{env.GCS_UPLOAD_DIR}}/ta.tar ta
-          rm -rf ta
-          tar xf ${{env.GCS_UPLOAD_DIR}}/ta.tar -C ${{env.GCS_UPLOAD_DIR}}
-          rm ${{env.GCS_UPLOAD_DIR}}/ta.tar
-          cp scripts/gha/gcs_uploader.py  ${{env.GCS_UPLOAD_DIR}}/scripts/gha-encrypted/
-          cp scripts/gha/integration_testing/gcs.py ${{env.GCS_UPLOAD_DIR}}/scripts/gha/integration_testing/
-          cp scripts/gha/gcs_uploader.py ${{env.GCS_UPLOAD_DIR}}/scripts/gha/
-          cp scripts/gha-encrypted/gcs_key_file.json ${{env.GCS_UPLOAD_DIR}}//scripts/gha-encrypted/
       - name: Set CLOUDSDK_PYTHON (Windows)
         shell: bash
         if: startsWith(matrix.os, 'windows') && !cancelled()
@@ -366,9 +337,7 @@ jobs:
         shell: bash
         if: ${{ !cancelled() }}
         run: |
-          pushd ${{env.GCS_UPLOAD_DIR}}
           python scripts/gha/gcs_uploader.py --testapp_dir ta --key_file scripts/gha-encrypted/gcs_key_file.json
-          popd
       - name: Download log artifacts
         if: ${{ needs.check_trigger.outputs.should_update_pr && failure() && !cancelled() }}
         uses: actions/download-artifact@v2.0.8

cmake/external/boringssl.cmake

@@ -21,15 +21,20 @@ endif()
 set(patch_file 
   ${CMAKE_CURRENT_LIST_DIR}/../../scripts/git/patches/boringssl/0001-disable-C4255-converting-empty-params-to-void.patch)
 
+set(commit_tag 83da28a68f32023fd3b95a8ae94991a07b1f6c62)
+
 ExternalProject_Add(
   boringssl
+  
+  DOWNLOAD_COMMAND 
+    COMMAND git init boringssl
+    COMMAND cd boringssl && git fetch --depth=1 https://github.com/google/boringssl ${commit_tag} && git reset --hard FETCH_HEAD
 
-  GIT_REPOSITORY https://github.com/google/boringssl/
-  GIT_TAG 83da28a68f32023fd3b95a8ae94991a07b1f6c62
-  PATCH_COMMAND git apply ${patch_file}
+  PATCH_COMMAND git apply ${patch_file} && git gc --aggressive
   PREFIX ${PROJECT_BINARY_DIR}
   CONFIGURE_COMMAND ""
   BUILD_COMMAND     ""
   INSTALL_COMMAND   ""
   TEST_COMMAND      ""
 )
+