Merge pull request #86 from flutter-news-app-full-source-code/fix-Decouple-Initial-Data-Fetch-from-Router-Configuration

Fix decouple initial data fetch from router configuration

Author: fulleni

lib/bootstrap.dart

@@ -7,11 +7,10 @@ import 'package:data_api/data_api.dart';
 import 'package:data_client/data_client.dart';
 import 'package:data_inmemory/data_inmemory.dart';
 import 'package:data_repository/data_repository.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
-import 'package:flutter_news_app_mobile_client_full_source_code/ads/ad_provider.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/ads/ad_service.dart';
-import 'package:flutter/foundation.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/ads/admob_ad_provider.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/ads/no_op_ad_provider.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/app/app.dart';
@@ -47,7 +46,7 @@ Future<Widget> bootstrap(
   // Initialize AdProvider based on platform.
   // On web, use a No-Op provider to prevent MissingPluginException,
   // as Google Mobile Ads SDK does not support native ads on web.
-  final AdProvider adProvider = kIsWeb
+  final adProvider = kIsWeb
       ? NoOpAdProvider(logger: logger)
       : AdMobAdProvider(logger: logger);
 

lib/headlines-feed/view/headlines_feed_page.dart

@@ -43,6 +43,23 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage> {
     super.initState();
     // Add listener to trigger pagination when scrolling near the bottom.
     _scrollController.addListener(_onScroll);
+
+    // Dispatch the initial fetch event for the headlines feed.
+    // This is intentionally placed in `initState` and wrapped in `addPostFrameCallback`
+    // to ensure the `BuildContext` is fully initialized and stable.
+    // This prevents the "Tried to listen to an InheritedWidget in a life-cycle
+    // that will never be called again" error, which occurred when the event
+    // was dispatched from the router's `BlocProvider` `create` method,
+    // as that context could be disposed before asynchronous operations completed.
+    WidgetsBinding.instance.addPostFrameCallback((_) {
+      if (mounted) {
+        context.read<HeadlinesFeedBloc>().add(
+              HeadlinesFeedFetchRequested(
+                adThemeStyle: AdThemeStyle.fromTheme(Theme.of(context)),
+              ),
+            );
+      }
+    });
   }
 
   @override

lib/router/router.dart

@@ -12,7 +12,6 @@ import 'package:flutter_news_app_mobile_client_full_source_code/account/view/man
 import 'package:flutter_news_app_mobile_client_full_source_code/account/view/manage_followed_items/topics/followed_topics_list_page.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/account/view/saved_headlines_page.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/ads/ad_service.dart';
-import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/ad_theme_style.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/app/bloc/app_bloc.dart';
 import 'package:flutter_news_app_mobile_client_full_source_code/app/config/config.dart'
     as local_config;
@@ -372,10 +371,6 @@ GoRouter createRouter({
                         .read<DataRepository<UserContentPreferences>>(),
                     feedDecoratorService: feedDecoratorService,
                     appBloc: context.read<AppBloc>(),
-                  )..add(
-                    HeadlinesFeedFetchRequested(
-                      adThemeStyle: AdThemeStyle.fromTheme(Theme.of(context)),
-                    ),
                   );
                 },
               ),