Skip to content

Commit 0dfd936

Browse files
committed
refactor(account): remove duplicate trailing button code
- Remove unused colorScheme variable - Delete trailing button code from all HeadlineTile widgets - Simplify headline tile creation based on image style
1 parent b045ff8 commit 0dfd936

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

lib/account/view/saved_headlines_page.dart

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ class SavedHeadlinesPage extends StatelessWidget {
2323
final l10n = AppLocalizationsX(context).l10n;
2424
final theme = Theme.of(context);
2525
final textTheme = theme.textTheme;
26-
final colorScheme = theme.colorScheme;
2726

2827
return Scaffold(
2928
appBar: AppBar(
@@ -88,48 +87,25 @@ class SavedHeadlinesPage extends StatelessWidget {
8887
appState.settings?.feedSettings.feedItemImageStyle ??
8988
FeedItemImageStyle.smallThumbnail;
9089

91-
final trailingButton = IconButton(
92-
icon: Icon(Icons.delete_outline, color: colorScheme.error),
93-
tooltip: l10n.headlineDetailsRemoveFromSavedTooltip,
94-
onPressed: () {
95-
final updatedSavedHeadlines = List<Headline>.from(
96-
savedHeadlines,
97-
)..removeWhere((h) => h.id == headline.id);
98-
99-
final updatedPreferences = userContentPreferences.copyWith(
100-
savedHeadlines: updatedSavedHeadlines,
101-
);
102-
103-
context.read<AppBloc>().add(
104-
AppUserContentPreferencesChanged(
105-
preferences: updatedPreferences,
106-
),
107-
);
108-
},
109-
);
110-
11190
Widget tile;
11291
switch (imageStyle) {
11392
case FeedItemImageStyle.hidden:
11493
tile = HeadlineTileTextOnly(
11594
headline: headline,
11695
onHeadlineTap: () =>
11796
HeadlineTapHandler.handleHeadlineTap(context, headline),
118-
trailing: trailingButton,
11997
);
12098
case FeedItemImageStyle.smallThumbnail:
12199
tile = HeadlineTileImageStart(
122100
headline: headline,
123101
onHeadlineTap: () =>
124102
HeadlineTapHandler.handleHeadlineTap(context, headline),
125-
trailing: trailingButton,
126103
);
127104
case FeedItemImageStyle.largeThumbnail:
128105
tile = HeadlineTileImageTop(
129106
headline: headline,
130107
onHeadlineTap: () =>
131108
HeadlineTapHandler.handleHeadlineTap(context, headline),
132-
trailing: trailingButton,
133109
);
134110
}
135111
return tile;

0 commit comments

Comments
 (0)