Skip to content

Commit 1ef4ee7

Browse files
committed
fix(headlines-search): inject ad placeholders instead of ads in search results and pagination
- Replace `injectAds` with `injectAdPlaceholders` in search pagination and results - Clear previous ad cache for new searches - Update comments to reflect change from ads to ad placeholders
1 parent b34a2dc commit 1ef4ee7

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

lib/headlines-search/bloc/headlines_search_bloc.dart

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import 'package:bloc_concurrency/bloc_concurrency.dart';
55
import 'package:core/core.dart';
66
import 'package:data_repository/data_repository.dart';
77
import 'package:equatable/equatable.dart';
8+
import 'package:flutter_news_app_mobile_client_full_source_code/ads/ad_cache_service.dart';
89
import 'package:flutter_news_app_mobile_client_full_source_code/ads/models/ad_theme_style.dart';
910
import 'package:flutter_news_app_mobile_client_full_source_code/app/bloc/app_bloc.dart';
1011
import 'package:flutter_news_app_mobile_client_full_source_code/shared/services/feed_decorator_service.dart';
@@ -108,8 +109,9 @@ class HeadlinesSearchBloc
108109
);
109110
return;
110111
}
111-
// For search pagination, only inject ads.
112-
final injectedItems = await _feedDecoratorService.injectAds(
112+
// For search pagination, only inject ad placeholders.
113+
final injectedItems =
114+
await _feedDecoratorService.injectAdPlaceholders(
113115
feedItems: headlines,
114116
user: currentUser,
115117
adConfig: appConfig.adConfig,
@@ -185,7 +187,8 @@ class HeadlinesSearchBloc
185187
}
186188
}
187189

188-
// New search
190+
// New search, clear previous ad cache.
191+
AdCacheService().clearAllAds();
189192
emit(
190193
HeadlinesSearchLoading(
191194
lastSearchTerm: searchTerm,
@@ -216,8 +219,8 @@ class HeadlinesSearchBloc
216219
);
217220
return;
218221
}
219-
// For search results, only inject ads.
220-
processedItems = await _feedDecoratorService.injectAds(
222+
// For search results, only inject ad placeholders.
223+
processedItems = await _feedDecoratorService.injectAdPlaceholders(
221224
feedItems: headlines,
222225
user: currentUser,
223226
adConfig: appConfig.adConfig,

0 commit comments

Comments
 (0)