Skip to content

Commit 526d40d

Browse files
committed
refactor(headlines-feed): improve exception handling and layout
- Replace hardcoded exception message with l10n support - Simplify padding definition in SavedFiltersBar
1 parent a5574c4 commit 526d40d

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

lib/headlines-feed/view/headlines_feed_page.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,7 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage> {
150150
if (state.status == HeadlinesFeedStatus.failure &&
151151
state.feedItems.isEmpty) {
152152
return FailureStateWidget(
153-
//TODO(fulleni): l10n.
154-
exception:
155-
state.error ??
156-
const UnknownException('Failed to load headlines feed.'),
153+
exception: state.error ?? UnknownException(l10n.unknownError),
157154
onRetry: () => context.read<HeadlinesFeedBloc>().add(
158155
HeadlinesFeedRefreshRequested(
159156
adThemeStyle: AdThemeStyle.fromTheme(theme),
@@ -200,9 +197,7 @@ class _HeadlinesFeedPageState extends State<HeadlinesFeedPage> {
200197
slivers: [
201198
const SliverToBoxAdapter(
202199
child: Padding(
203-
padding: EdgeInsets.symmetric(
204-
horizontal: AppSpacing.md,
205-
),
200+
padding: EdgeInsets.symmetric(horizontal: AppSpacing.md),
206201
child: SavedFiltersBar(),
207202
),
208203
),

0 commit comments

Comments
 (0)