Skip to content

Commit 52c3c7c

Browse files
committed
refactor(feed): remove savedFilter from HeadlinesFeedFiltersApplied event
Removes the `savedFilter` property from the `HeadlinesFeedFiltersApplied` event. The logic for determining the active filter ID (whether it's a saved filter or a new 'custom' one) is being centralized within the `HeadlinesFeedBloc`. The bloc will now compare the incoming filter against the list of saved filters, making this property redundant and simplifying the event's API.
1 parent 2f63814 commit 52c3c7c

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

lib/headlines-feed/bloc/headlines_feed_event.dart

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,28 @@ final class HeadlinesFeedRefreshRequested extends HeadlinesFeedEvent {
5252
/// Event triggered when a new set of filters, selected by the user,
5353
/// should be applied to the headlines feed.
5454
/// {@endtemplate}
55+
///
56+
/// The `activeFilterId` is now determined within the `HeadlinesFeedBloc` by
57+
/// comparing the applied filter against the list of saved filters. This makes
58+
/// passing a `savedFilter` object on this event redundant.
5559
final class HeadlinesFeedFiltersApplied extends HeadlinesFeedEvent {
5660
/// {@macro headlines_feed_filters_applied}
5761
///
5862
/// Contains the complete [HeadlineFilter] configuration to be applied.
5963
const HeadlinesFeedFiltersApplied({
6064
required this.filter,
6165
required this.adThemeStyle,
62-
this.savedFilter,
6366
});
6467

6568
/// The [HeadlineFilter] containing the selected categories, sources,
6669
/// and/or countries.
6770
final HeadlineFilter filter;
6871

69-
/// The optional [SavedFilter] that this filter corresponds to.
70-
/// This is used to correctly set the active filter ID when a new
71-
/// filter is saved and immediately applied.
72-
final SavedFilter? savedFilter;
73-
7472
/// The current ad theme style of the application.
7573
final AdThemeStyle adThemeStyle;
7674

7775
@override
78-
List<Object?> get props => [filter, adThemeStyle, savedFilter];
76+
List<Object?> get props => [filter, adThemeStyle];
7977
}
8078

8179
/// {@template headlines_feed_filters_cleared}

0 commit comments

Comments
 (0)