Skip to content

Commit 5eca8b1

Browse files
committed
feat(feed_decorators): improve layout and accessibility for popup menu
- Replace more_vert icon with more_horiz for better alignment - Use Positioned.directional and Directionality.of() to ensure correct positioning in different locales - Wrap PopupMenuButton in Directionality widget for correct text direction handling
1 parent ba6b10c commit 5eca8b1

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

lib/feed_decorators/widgets/call_to_action_decorator_widget.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,12 @@ class CallToActionDecoratorWidget extends StatelessWidget {
7171
),
7272
),
7373
if (onDismiss != null)
74-
Positioned(
74+
Positioned.directional(
7575
top: AppSpacing.xs,
76-
right: AppSpacing.xs,
76+
end: AppSpacing.xs,
77+
textDirection: Directionality.of(context),
7778
child: PopupMenuButton<void>(
78-
icon: const Icon(Icons.more_vert),
79+
icon: const Icon(Icons.more_horiz),
7980
tooltip: l10n.decoratorDismissAction,
8081
onSelected: (_) => onDismiss!(),
8182
itemBuilder: (BuildContext context) => [

lib/feed_decorators/widgets/content_collection_decorator_widget.dart

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -113,16 +113,19 @@ class _ContentCollectionViewState extends State<_ContentCollectionView> {
113113
),
114114
),
115115
if (widget.onDismiss != null)
116-
PopupMenuButton<String>(
117-
icon: const Icon(Icons.more_vert),
118-
tooltip: l10n.decoratorDismissAction,
119-
onSelected: (_) => widget.onDismiss!(),
120-
itemBuilder: (BuildContext context) => [
121-
PopupMenuItem<String>(
122-
value: 'dismiss',
123-
child: Text(l10n.decoratorDismissAction),
124-
),
125-
],
116+
Directionality(
117+
textDirection: Directionality.of(context),
118+
child: PopupMenuButton<String>(
119+
icon: const Icon(Icons.more_horiz),
120+
tooltip: l10n.decoratorDismissAction,
121+
onSelected: (_) => widget.onDismiss!(),
122+
itemBuilder: (BuildContext context) => [
123+
PopupMenuItem<String>(
124+
value: 'dismiss',
125+
child: Text(l10n.decoratorDismissAction),
126+
),
127+
],
128+
),
126129
),
127130
],
128131
),

0 commit comments

Comments
 (0)