Skip to content

Commit 633cffd

Browse files
committed
refactor(feed_decorators): standardize dismiss action text
1 parent 0b2a6c6 commit 633cffd

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

lib/shared/widgets/feed_decorators/call_to_action_decorator_widget.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,12 @@ class CallToActionDecoratorWidget extends StatelessWidget {
7676
right: AppSpacing.xs,
7777
child: PopupMenuButton<void>(
7878
icon: const Icon(Icons.more_vert),
79-
tooltip: l10n.manageFiltersDeleteTooltip,
79+
tooltip: l10n.decoratorDismissAction,
8080
onSelected: (_) => onDismiss!(),
8181
itemBuilder: (BuildContext context) => [
8282
PopupMenuItem<void>(
8383
value: null,
84-
// TODO(fulleni): Replace with a localized string.
85-
child: Text(l10n.savedFiltersMenuDelete),
84+
child: Text(l10n.decoratorDismissAction),
8685
),
8786
],
8887
),

lib/shared/widgets/feed_decorators/content_collection_decorator_widget.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import 'package:core/core.dart';
22
import 'package:flutter/material.dart';
3+
import 'package:flutter_bloc/flutter_bloc.dart';
4+
import 'package:flutter_news_app_mobile_client_full_source_code/app/bloc/app_bloc.dart';
35
import 'package:flutter_news_app_mobile_client_full_source_code/l10n/l10n.dart';
46
import 'package:flutter_news_app_mobile_client_full_source_code/shared/widgets/feed_decorators/suggestion_item_widget.dart';
57
import 'package:ui_kit/ui_kit.dart';
@@ -113,13 +115,12 @@ class _ContentCollectionViewState extends State<_ContentCollectionView> {
113115
if (widget.onDismiss != null)
114116
PopupMenuButton<void>(
115117
icon: const Icon(Icons.more_vert),
116-
tooltip: l10n.manageFiltersDeleteTooltip,
118+
tooltip: l10n.decoratorDismissAction,
117119
onSelected: (_) => widget.onDismiss!(),
118120
itemBuilder: (BuildContext context) => [
119121
PopupMenuItem<void>(
120122
value: null,
121-
// TODO(fulleni): Replace with a localized string.
122-
child: Text(l10n.savedFiltersMenuDelete),
123+
child: Text(l10n.decoratorDismissAction),
123124
),
124125
],
125126
),

0 commit comments

Comments
 (0)