Skip to content

Commit 6d0073e

Browse files
committed
feat(localization): add generic search hint text and update headlines search
- Add generic search hint text for localization in app_ar.arb and app_en.arb - Update headlines search page to use localized search hint text - Remove TODO comment regarding search hint text localization
1 parent 8d57c7d commit 6d0073e

File tree

6 files changed

+21
-2
lines changed

6 files changed

+21
-2
lines changed

lib/headlines-search/view/headlines_search_page.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,7 @@ class _HeadlinesSearchViewState extends State<_HeadlinesSearchView> {
187187
controller: _textController,
188188
style: appBarTheme.titleTextStyle ?? textTheme.titleMedium,
189189
decoration: InputDecoration(
190-
// TODO(fulleni): Create a similar localization extension for hint text.
191-
hintText: 'Search...',
190+
hintText: l10n.searchHintTextGeneric,
192191
hintStyle: textTheme.bodyMedium?.copyWith(
193192
color:
194193
(appBarTheme.titleTextStyle?.color ??

lib/l10n/app_localizations.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -998,6 +998,12 @@ abstract class AppLocalizations {
998998
/// **'e.g., AI advancements, Mars rover...'**
999999
String get searchHintTextHeadline;
10001000

1001+
/// Generic hint text for search input fields
1002+
///
1003+
/// In en, this message translates to:
1004+
/// **'Search...'**
1005+
String get searchHintTextGeneric;
1006+
10011007
/// Hint text for searching categories
10021008
///
10031009
/// In en, this message translates to:

lib/l10n/app_localizations_ar.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -487,6 +487,9 @@ class AppLocalizationsAr extends AppLocalizations {
487487
String get searchHintTextHeadline =>
488488
'مثال: تطورات الذكاء الاصطناعي, مركبة المريخ...';
489489

490+
@override
491+
String get searchHintTextGeneric => 'بحث...';
492+
490493
@override
491494
String get searchHintTextCategory => 'مثال: تكنولوجيا, رياضة, مالية...';
492495

lib/l10n/app_localizations_en.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -488,6 +488,9 @@ class AppLocalizationsEn extends AppLocalizations {
488488
@override
489489
String get searchHintTextHeadline => 'e.g., AI advancements, Mars rover...';
490490

491+
@override
492+
String get searchHintTextGeneric => 'Search...';
493+
491494
@override
492495
String get searchHintTextCategory => 'e.g., Technology, Sports, Finance...';
493496

lib/l10n/arb/app_ar.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,10 @@
618618
"@searchHintTextHeadline": {
619619
"description": "Hint text for searching headlines"
620620
},
621+
"searchHintTextGeneric": "بحث...",
622+
"@searchHintTextGeneric": {
623+
"description": "Generic hint text for search input fields"
624+
},
621625
"searchHintTextCategory": "مثال: تكنولوجيا, رياضة, مالية...",
622626
"@searchHintTextCategory": {
623627
"description": "Hint text for searching categories"

lib/l10n/arb/app_en.arb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,10 @@
619619
"@searchHintTextHeadline": {
620620
"description": "Hint text for searching headlines"
621621
},
622+
"searchHintTextGeneric": "Search...",
623+
"@searchHintTextGeneric": {
624+
"description": "Generic hint text for search input fields"
625+
},
622626
"searchHintTextCategory": "e.g., Technology, Sports, Finance...",
623627
"@searchHintTextCategory": {
624628
"description": "Hint text for searching categories"

0 commit comments

Comments
 (0)