Skip to content

Commit 749244d

Browse files
committed
refactor(feed_decorators): remove DecoratorDismissedWidget and update dismissal behavior
- Remove DecoratorDismissedWidget class and its associated imports - Update FeedDecoratorLoaderWidget to set _state to none instead of dismissed when hiding the decorator - Remove case for _DecoratorState.dismissed in the builder method
1 parent 048d432 commit 749244d

File tree

2 files changed

+2
-72
lines changed

2 files changed

+2
-72
lines changed

lib/feed_decorators/widgets/decorator_dismissed_widget.dart

Lines changed: 0 additions & 65 deletions
This file was deleted.

lib/feed_decorators/widgets/feed_decorator_loader_widget.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import 'package:flutter_bloc/flutter_bloc.dart';
77
import 'package:flutter_news_app_mobile_client_full_source_code/app/bloc/app_bloc.dart';
88
import 'package:flutter_news_app_mobile_client_full_source_code/feed_decorators/widgets/call_to_action_decorator_widget.dart';
99
import 'package:flutter_news_app_mobile_client_full_source_code/feed_decorators/widgets/content_collection_decorator_widget.dart';
10-
import 'package:flutter_news_app_mobile_client_full_source_code/feed_decorators/widgets/decorator_dismissed_widget.dart';
1110
import 'package:flutter_news_app_mobile_client_full_source_code/headlines-feed/bloc/headlines_feed_bloc.dart';
1211
import 'package:flutter_news_app_mobile_client_full_source_code/router/routes.dart';
1312
import 'package:logging/logging.dart';
@@ -23,9 +22,6 @@ enum _DecoratorState {
2322
/// A decorator has been successfully loaded and is ready to be displayed.
2423
success,
2524

26-
/// The user has dismissed the decorator.
27-
dismissed,
28-
2925
/// No decorator is due to be shown, or loading failed. The widget should
3026
/// render nothing.
3127
none,
@@ -271,9 +267,9 @@ class _FeedDecoratorLoaderWidgetState extends State<FeedDecoratorLoaderWidget> {
271267
),
272268
);
273269

274-
// Update internal state to show the dismissed widget.
270+
// Update internal state to hide the widget completely.
275271
if (mounted) {
276-
setState(() => _state = _DecoratorState.dismissed);
272+
setState(() => _state = _DecoratorState.none);
277273
}
278274
}
279275

@@ -427,7 +423,6 @@ class _FeedDecoratorLoaderWidgetState extends State<FeedDecoratorLoaderWidget> {
427423
),
428424
),
429425
_DecoratorState.success => _decoratorWidget ?? const SizedBox.shrink(),
430-
_DecoratorState.dismissed => const DecoratorDismissedWidget(),
431426
_DecoratorState.none => const SizedBox.shrink(),
432427
};
433428
}

0 commit comments

Comments
 (0)