Skip to content

Commit 8222a29

Browse files
committed
fix(headlines-feed): remove redundant 'decoratedItems' property
- Remove 'feedWithDecorator.decoratedItems' as it's no longer needed - Update feed decoration and ad placeholder injection process - Adjust comments and documentation accordingly
1 parent 711e3a9 commit 8222a29

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

lib/headlines-feed/bloc/headlines_feed_bloc.dart

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ part 'headlines_feed_state.dart';
2525
/// This BLoC is the central orchestrator for the news feed. Its core
2626
/// responsibilities include:
2727
/// - Fetching, filtering, and displaying headlines from a `DataRepository`.
28-
/// - Injecting dynamic content placeholders for ads and non-ad decorators
28+
/// - Injecting dynamic content placeholders for ads and decorators
2929
/// using the `AdService` and the new `FeedDecoratorService`.
3030
/// - Implementing a session-based in-memory caching strategy via
3131
/// [FeedCacheService] to provide a responsive user experience.
@@ -409,23 +409,23 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
409409
);
410410
final settings = _appBloc.state.settings;
411411

412-
// Step 1: Inject the non-ad decorator placeholder.
413-
final feedWithDecorator = await _feedDecoratorService.decorateFeed(
412+
// Step 1: Inject the decorator placeholder.
413+
final feedWithDecorator = _feedDecoratorService.decorateFeed(
414414
feedItems: headlineResponse.items,
415415
remoteConfig: appConfig,
416416
);
417417

418418
// Step 2: Inject ad placeholders into the resulting list.
419419
final fullyDecoratedFeed = await _adService.injectAdPlaceholders(
420-
feedItems: feedWithDecorator.decoratedItems,
420+
feedItems: feedWithDecorator,
421421
user: currentUser,
422422
adConfig: appConfig.adConfig,
423423
imageStyle: settings!.feedPreferences.headlineImageStyle,
424424
adThemeStyle: event.adThemeStyle,
425425
);
426426

427427
final newCachedFeed = CachedFeed(
428-
feedItems: fullyDecoratedFeed.decoratedItems,
428+
feedItems: fullyDecoratedFeed,
429429
hasMore: headlineResponse.hasMore,
430430
cursor: headlineResponse.cursor,
431431
lastRefreshedAt: DateTime.now(),
@@ -534,23 +534,23 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
534534

535535
final settings = _appBloc.state.settings;
536536

537-
// Step 1: Inject the non-ad decorator placeholder.
538-
final feedWithDecorator = await _feedDecoratorService.decorateFeed(
537+
// Step 1: Inject the decorator placeholder.
538+
final feedWithDecorator = _feedDecoratorService.decorateFeed(
539539
feedItems: headlineResponse.items,
540540
remoteConfig: appConfig,
541541
);
542542

543543
// Step 2: Inject ad placeholders into the resulting list.
544544
final fullyDecoratedFeed = await _adService.injectAdPlaceholders(
545-
feedItems: feedWithDecorator.decoratedItems,
545+
feedItems: feedWithDecorator,
546546
user: currentUser,
547547
adConfig: appConfig.adConfig,
548548
imageStyle: settings!.feedPreferences.headlineImageStyle,
549549
adThemeStyle: event.adThemeStyle,
550550
);
551551

552552
final newCachedFeed = CachedFeed(
553-
feedItems: fullyDecoratedFeed.decoratedItems,
553+
feedItems: fullyDecoratedFeed,
554554
hasMore: headlineResponse.hasMore,
555555
cursor: headlineResponse.cursor,
556556
lastRefreshedAt: DateTime.now(),
@@ -630,23 +630,23 @@ class HeadlinesFeedBloc extends Bloc<HeadlinesFeedEvent, HeadlinesFeedState> {
630630

631631
final settings = _appBloc.state.settings;
632632

633-
// Step 1: Inject the non-ad decorator placeholder.
634-
final feedWithDecorator = await _feedDecoratorService.decorateFeed(
633+
// Step 1: Inject the decorator placeholder.
634+
final feedWithDecorator = _feedDecoratorService.decorateFeed(
635635
feedItems: headlineResponse.items,
636636
remoteConfig: appConfig,
637637
);
638638

639639
// Step 2: Inject ad placeholders into the resulting list.
640640
final fullyDecoratedFeed = await _adService.injectAdPlaceholders(
641-
feedItems: feedWithDecorator.decoratedItems,
641+
feedItems: feedWithDecorator,
642642
user: currentUser,
643643
adConfig: appConfig.adConfig,
644644
imageStyle: settings!.feedPreferences.headlineImageStyle,
645645
adThemeStyle: event.adThemeStyle,
646646
);
647647

648648
final newCachedFeed = CachedFeed(
649-
feedItems: fullyDecoratedFeed.decoratedItems,
649+
feedItems: fullyDecoratedFeed,
650650
hasMore: headlineResponse.hasMore,
651651
cursor: headlineResponse.cursor,
652652
lastRefreshedAt: DateTime.now(),

0 commit comments

Comments
 (0)